chore: nemo-gym-reward-profiling skill: NVSkills integration#1449
Open
ananthsub wants to merge 5 commits into
Open
chore: nemo-gym-reward-profiling skill: NVSkills integration#1449ananthsub wants to merge 5 commits into
ananthsub wants to merge 5 commits into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
## Summary
- Move `.claude/skills/nemo-gym-reward-profiling/` to top-level
`skills/nemo-gym-reward-profiling/` so this PR touches files under
the central `team-request.yml` trigger allowlist (`skills/`,
`team-skills/`, `rules/team-rules/`, `plugins/`).
- Replace `.claude/skills/nemo-gym-reward-profiling/` with a symlink
to `../../skills/nemo-gym-reward-profiling` so Claude Code and
Cursor continue to discover the skill via the conventional
`.claude/skills/<name>/SKILL.md` path with no tool-side change.
- Add `license: Apache-2.0` to
`skills/nemo-gym-reward-profiling/SKILL.md` frontmatter.
- Add `skills/nemo-gym-reward-profiling/evals/evals.json` with
positive trigger cases (ng_run/ng_collect_rollouts/
ng_reward_profile workflow, repeated rollouts, materialized inputs)
and negative cases that delegate to sibling skills.
## Motivation
Prepares the `nemo-gym-reward-profiling` skill for NVSkills CI
signing. Per-skill scope keeps the diff small and lets NVSkills CI
evaluate one skill at a time. Other skills remain at
`.claude/skills/<name>/` until each has its own migration PR.
## Test plan
- [ ] Comment `/nvskills-ci` on this PR. Expect the request workflow
to dispatch (not skip) and `svc-nvskills-signing` to attach
`skill-card.md` and `skill.oms.sig` under
`skills/nemo-gym-reward-profiling/`.
- [ ] Claude Code discovers `nemo-gym-reward-profiling` via
`.claude/skills/nemo-gym-reward-profiling/SKILL.md` (follows symlink).
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
ananthsub
force-pushed
the
ci/nvskills-reward-profiling
branch
from
1c5e64c to
12de657
Compare
Apply the same content fixes validated on add-benchmark: - Add metadata.author and metadata.tags. - Tighten the description (the negative trigger to nemo-gym-debugging is retained). - Add a Purpose section and an Examples section, and rename Basic Workflow to Instructions. Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
- Shorten the description to under 150 characters. - Add Prerequisites, Limitations, and Troubleshooting sections. Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Contributor
Author
|
/nvskills-ci |
…outing - Stop assigning a placeholder API key and passing it on the command line in references/quick-start.md; require POLICY_ENDPOINT_KEY from the environment and resolve it at runtime via the oc.env resolver so the value never appears in process args or shell history (clears the PII/secret and CLI-exposure findings). - Add explicit do-not-activate routing to nemo-gym-debugging and add-benchmark. Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Contributor
Author
|
/nvskills-ci |
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
license: Apache-2.0to the frontmatter of.claude/skills/nemo-gym-reward-profiling/SKILL.md..claude/skills/nemo-gym-reward-profiling/evals/evals.jsonwith 3 positive trigger cases (pass@5 workflow, materialized_inputs vs rollouts explanation, partial profiling with ++allow_partial_rollouts) and 2 negative cases that delegate to sibling skills.Motivation
Prepares the
nemo-gym-reward-profilingskill for NVSkills CI signingTest plan
/nvskills-cion this PR. Expect a signature commit attachingskill-card.mdandskill.oms.sigunder.claude/skills/nemo-gym-reward-profiling/.