[POC] Expose retrieval SDG as a Data Designer recipe#14
Draft
oliverholworthy wants to merge 1 commit intoNVIDIA-NeMo:steve/retriever-sdgfrom
Draft
Conversation
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
435be07 to
f3eb730
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POC consumer for the Data Designer recipe discovery interface proposed in NVIDIA-NeMo/DataDesigner#613.
This keeps retrieval SDG in the external plugins repository, but makes it discoverable and runnable from Data Designer when the package is installed:
data-designer recipes list --output json data-designer recipes help retrieval-sdg data-designer preview --recipe retrieval-sdg -- --input-dir ./docsDesign
retrieval-sdgin thedata_designer.recipesentry point group.load_config_builder(params)for execution.build_typer_app()so Data Designer can inspect recipe-specific arguments and render help from the same Typer command shape used by the recipe.Included Fix
This also changes
EmbeddingDedupColumnConfig.get_column_emoji()to a static method. Data Designer calls column emoji helpers on the config class, so the previous instance method raised aTypeErrorduring report generation.Dependencies
This PR depends on the DataDesigner recipe discovery POC in NVIDIA-NeMo/DataDesigner#613, which itself builds on NVIDIA-NeMo/DataDesigner#612.