Skip to content

Specify merlin dependencies in setup.py to create release specifier #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oliverholworthy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Specify merlin dependencies in setup.py to create release specifier #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f49b059
Specify merlin dependencies in setup.py to create release specifier
oliverholworthy Jun 23, 2023
af26476
Simplify merlin_dependency using `~=` version specifier
oliverholworthy Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion requirements/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
merlin-core>=23.04.00
22 changes: 21 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import codecs
import itertools
import os
import re
import sys

from setuptools import find_namespace_packages, setup
Expand All @@ -38,8 +39,27 @@ def read_requirements(filename):
return [line for line in lineiter if line and not line.startswith("#")]


def merlin_dependency(package_name: str) -> str:
"""Get Merlin package dependency matching the current version.

Examples
--------

>>> merlin_dependency("merlin-core") # with version "23.07.00"
"merlin-core~=23.7.0"

>>> merlin_dependency("merlin-core") # with version "23.12.dev0+1.ge73d8ba"
"merlin-core"
"""
version = versioneer.get_version()
major, minor = map(int, re.match(r"(\d+).(\d+).*", version).groups())
if "dev" in version:
return package_name
return f"{package_name}~={major}.{minor}.0"


requirements = {
"base": read_requirements("requirements/base.txt"),
"base": read_requirements("requirements/base.txt") + [merlin_dependency("merlin-core")],
"tensorflow": read_requirements("requirements/tensorflow.txt"),
"pytorch": read_requirements("requirements/torch.txt"),
"torch": read_requirements("requirements/torch.txt"),
Expand Down