Skip to content

RO-13: Planlegging#857

Merged
jorgkv merged 32 commits intodevelopfrom
feature/RO-13-turplaner
Feb 27, 2026
Merged

RO-13: Planlegging#857
jorgkv merged 32 commits intodevelopfrom
feature/RO-13-turplaner

Conversation

@jorgkv
Copy link
Copy Markdown
Contributor

@jorgkv jorgkv commented Nov 7, 2025 •
edited
Loading

Husk å rebase denne jevnlig så vi ikke får så mye konflikter til slutt.
Hvis du vil teste import av GPX-spor, kan du bruke f.eks. https://gpx.studio/ til å lage GPS-filer. https://geojson.io/ kan brukes til å lage GeoJSON-filer.

TODO

  • Vi støtter bare lat/lon i appen, trenger vi sjekke om importerte geojson-filer har koordinater som ligner på andre ting? (gpx støtter bare lat lon)
  • Beregne lengde på tur under import / lagring?
  • Fjern hardkodede turer i kartet (de som ligger i Asker)
  • Fjerne logging vi ikke trenger lengre (men som kan være nyttig å ha der under testing)
  • Kjøre copilot-review
  • Sjekke hvor mye plass vi bruker i LocalStorage med 4-5 kladder + en god del turer importert. Hvis vi nærmer oss grensa på 5 mb? så burde vi kanskje hatt en slags håndtering av det, at vi melder i fra om at maks antall turer er importert. Tipper at det skal mye til for å nå den grensa, men siden dette med turer potensielt kan overskrive kladder dersom man når plassgrensa ? så burde vi undersøke det.
  • Gjøre det lettere å velge et spor i kartet, for å se navn og beskrivelse. Det virker som "hover-området" for sporet er for smalt (fikses i Mer musevennlig visning av navn og beskrivelse #903)
  • Detaljsida for tur er ikke veldig tilpassa for web, kartet kunne tatt opp (nesten) hele skjermen, og tur-metadata bare tatt opp en liten bit på siden av kartet.
  • Oppdatere til siste versjon av designsystemet
  • Vise feilmelding hvis vi ikke får til å importere en fil
  • Lista er vanskelig å scrolle i Android. Det funker ikke som de andre sidene. Kan ikke bare "dra" sida opp eller ned, jeg må treffe scrollbar som er veldig smal
  • Tag "Vises i kart" i lista blir kuttet og helt borte når navn på spor er langt
  • det er noe rart med punkt-ikonene:
image

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 7, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 7, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net

@jorgkv jorgkv force-pushed the feature/RO-13-turplaner branch from c705c23 to 7e6f93c Compare November 7, 2025 14:12
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 7, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net

2 similar comments
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 7, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 7, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net

@gruble gruble force-pushed the feature/RO-13-turplaner branch from d8df8b1 to b75d8f7 Compare November 13, 2025 11:12
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 13, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net

3 similar comments
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 14, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 17, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 17, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net

@gruble gruble changed the title RO-13: Turplanlegging RO-13: Planlegging Nov 21, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 5, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 8, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net

@gruble gruble force-pushed the feature/RO-13-turplaner branch from 50872a6 to 63052cc Compare December 15, 2025 14:30
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 15, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net

3 similar comments
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 16, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 16, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 16, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net

jorgkv
jorgkv commented Dec 17, 2025
View reviewed changes
Comment thread src/app/core/services/geojson/geojson.service.ts Outdated
jorgkv
jorgkv commented Dec 17, 2025
View reviewed changes
Comment thread src/app/core/services/geojson/geojson.service.ts Outdated
jorgkv
jorgkv commented Dec 17, 2025
View reviewed changes
Comment thread src/app/pages/plans/plan/plan.page.ts Outdated
@jorgkv jorgkv requested a review from Copilot December 17, 2025 09:12
Copilot AI reviewed Dec 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements "RO-13: Planlegging" - a new feature for importing, managing, and displaying GPS tracks (GPX and GeoJSON files) in the application. It adds a "Plans" tab where users can upload track files, view them on the map, and manage metadata like names and descriptions.

Key Changes

  • Added new "Plans" tab with file import functionality supporting GPX and GeoJSON formats
  • Integrated NVE Design System components for UI consistency
  • Implemented GeoJSON storage service with IndexedDB persistence
  • Enhanced map component to display multiple imported tracks with click interactions
  • Added Source Sans Pro fonts to support the NVE Design System

Reviewed changes

Copilot reviewed 25 out of 38 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tsconfig.json Updated TypeScript target to es2023 and module to esnext
src/main.ts Added registration for NVE Design System icon library
src/global.scss Added NVE Design System theme and Source Sans Pro font imports
src/assets/icon/*.svg Added new SVG icons for plans feature (tour, input, delete, check, calendar, etc.)
src/assets/i18n/*.json Added Norwegian and English translations for plans feature
src/app/pages/tabs/* Updated tabs infrastructure to include new "Plans" tab
src/app/pages/plans/* New pages for plan list and detail views with file upload functionality
src/app/core/services/geojson/* New service for managing GeoJSON storage and metadata
src/app/modules/map/* Enhanced map component to display imported tracks with metadata
package.json Added dependencies for GeoJSON processing (@tmcw/togeojson, @Turf packages, nve-designsystem)

Comment thread src/app/pages/plans/plan/plan.page.html Outdated
Comment thread src/app/pages/plans/plan/plan.page.html Outdated
Comment thread src/app/pages/plans/plans.page.ts Outdated
Comment thread src/app/pages/plans/plans.page.ts Outdated
Comment thread src/app/core/services/geojson/geojson.service.ts Outdated
jorgkv
jorgkv commented Dec 17, 2025
View reviewed changes
Comment thread src/app/modules/map/components/map/map.component.ts Outdated
jorgkv
jorgkv commented Dec 17, 2025
View reviewed changes
Comment thread src/app/pages/plans/plan/plan.page.html Outdated
jorgkv
jorgkv commented Dec 17, 2025
View reviewed changes
Comment thread src/app/core/services/database/database.service.ts Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 19, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net

@gruble gruble requested a review from Copilot December 19, 2025 09:52
@jorgkv jorgkv force-pushed the feature/RO-13-turplaner branch from 0aaf5a0 to e043030 Compare February 27, 2026 10:19
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 27, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net

@jorgkv jorgkv marked this pull request as ready for review February 27, 2026 10:25
@jorgkv jorgkv requested a review from Copilot February 27, 2026 10:26
Copilot AI reviewed Feb 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 40 out of 53 changed files in this pull request and generated 12 comments.

Comment thread src/global.scss Outdated
Comment thread src/main.ts
Comment thread src/app/pages/plans/plans.page.html Outdated
Comment thread src/app/pages/plans/plans.page.ts
Comment thread src/app/pages/plans/plans.page.ts
Comment thread src/app/pages/plans/plans.page.ts
Comment thread src/app/pages/plans/plan/plan.page.html Outdated
Comment thread src/app/modules/map/components/map/map.component.ts
Comment thread src/app/modules/map/components/map/map.component.html
Comment thread src/assets/i18n/en.json Outdated
gruble
gruble approved these changes Feb 27, 2026
View reviewed changes
Comment thread src/global.scss Outdated
@jorgkv
Oppdater designsystem og fiks review comments
349be3b 
Fjerner endringer i CSP. Fjerner ubrukte skrifttyper. Legger til oversettelser som manglet. Forbedrer feilhåndtering ved filopplasting.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 27, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 27, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 27, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 27, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net

@jorgkv jorgkv merged commit bcbfdb9 into develop Feb 27, 2026
8 checks passed
@jorgkv jorgkv deleted the feature/RO-13-turplaner branch February 27, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amish1188 amish1188 amish1188 left review comments

Copilot code review Copilot Copilot left review comments

@gruble gruble gruble approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jorgkv @amish1188 @gruble