RO-3008: legge til info tekster under lista#846
Open
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-846.westeurope.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-846.westeurope.azurestaticapps.net |
gruble
requested changes
Oct 29, 2025
Contributor
gruble
left a comment
gruble
left a comment
There was a problem hiding this comment.
Fin beskrivelse i PR.
Fine tekster.
Det ser ut om det har skjedd noe med bredden av enkelte observasjonskort, se sammenligning mellom PR og regobs.no:
| export class ListEndInfoComponent { | ||
| @Input() maxItemsFetched = false; | ||
| @Input() registrationsLength = 0; | ||
| @Input() registrationsCount = 0; |
Contributor
There was a problem hiding this comment.
Jeg skjønner ikke forskjell på registrationsLength og registrationsCount. Får du til å bruke variabelnavn som er mer presise eller dokumentere hva som er hva?
| imports: [IonIcon, TranslatePipe], | ||
| }) | ||
| /** | ||
| * Viser informasjonstekster i bunnen av observasjonslister |
| <ion-infinite-scroll (ionInfinite)="loadNextPage()" [disabled]="disableInfiniteScroll()"> | ||
| <ion-infinite-scroll-content> </ion-infinite-scroll-content> | ||
| </ion-infinite-scroll> | ||
| <app-list-end-info |
Contributor
There was a problem hiding this comment.
Skal vi vise denne når vi laster neste side?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Har lagt til en ny komponent som viser informasjon basert på hvilken tilstand som er aktiv.
Tekstene som vises er:
"Prøv å endre kartutsnitt eller filter for å se flere observasjoner"
"Lista kan kun vise 100 observasjoner, prøv å endre kartutsnitt eller filter for å begrense."
I tillegg er noen ubrukte nøkler fjernet/justert i språkfilene.