Merged
Conversation
…ons/SponsorActivitiesDesktopSection.tsx Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
- SponsorActivitiesDesktopSection.tsx: リファクタリングの残骸により壊れていたJSXを削除 - globals.css: 産学局用の --color-industry-university テーマ変数を追加 - createPurchaseOrderPdf.ts / createPurchaseReportPdf.ts: BUREAUS を id で検索するよう修正し、bureauID=7 でのクラッシュとオフバイワンを解消 Co-Authored-By: TkymHrt <23.h.takayama.nutfes@gmail.com>
ネイティブのtitle属性に戻すことで、オーバーフロー境界で切り取られる 問題を回避 Co-Authored-By: TkymHrt <23.h.takayama.nutfes@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- min-w-245は無効なTailwindクラスのためmin-w-[980px]に戻す - 産学局用の--color-industry-university CSS変数をglobals.cssに追加し、BureauLabelのスタイル崩れを防止 Co-Authored-By: TkymHrt <23.h.takayama.nutfes@gmail.com>
Deploying finansu with
|
| Latest commit: |
7ca8bac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e75373f5.finansu.pages.dev |
| Branch Preview URL: | https://feat-yama-refactor-sponsor-u-6h4z.finansu.pages.dev |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
BUREAUS[bureauID]は配列インデックス(0始まり)としてDBのbureauID(1始まり)を使用しており、 新規追加した産学局(id=7)でundefinedとなりクラッシュするバグを修正。 BUREAUS.find((b) => b.id === bureauID)?.name のパターンに変更。 Co-Authored-By: TkymHrt <23.h.takayama.nutfes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
対応Issue
resolve #0
概要
スポンサー活動の管理において、新たに「産学局」を追加し、UI上での表示を改善しました。
主な変更点：
画面スクリーンショット等
URLスクリーンショット
テスト項目
備考
特になし