Fix/hikahana/unify format rules tamesu#1077
Merged
Wakai111 merged 6 commits intofix/wakape/unify-format-rulesfrom Mar 28, 2026
Merged
Fix/hikahana/unify format rules tamesu#1077Wakai111 merged 6 commits intofix/wakape/unify-format-rulesfrom
Wakai111 merged 6 commits intofix/wakape/unify-format-rulesfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the project's VS Code settings to enforce Prettier configurations and enable ESLint's flat config, while removing the automatic import organization on save. The majority of the code changes are automated formatting updates to JSX elements and Tailwind CSS class strings across numerous components. Feedback was provided regarding a specific formatting regression in SponsorActivitiesDesktopSection.tsx that reduces readability and is inconsistent with the rest of the PR's formatting style.
Deploying finansu with
|
| Latest commit: |
c3a97f3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4a9590ef.finansu.pages.dev |
| Branch Preview URL: | https://fix-hikahana-unify-format-ru.finansu.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
対応Issue
resolve #0
概要
]以下、codex生成
このブランチでやったことは2つです。
.vscode/settings.json を、VSCode 保存時の挙動が CLI とズレにくいように修正しました。具体的には source.organizeImports を外し、view/next-project の local Prettier を使うよう prettier.prettierPath と prettier.requireConfig、eslint.useFlatConfig を追加しています。
.github/workflows/auto-prettier.yml は、依存解決のブレを減らすために pnpm install --frozen-lockfile にし、さらに CI ログ確認の結果を踏まえて pnpm/action-setup のバージョンをローカル Docker の view と同じ 10.28.0 に固定しました。
調査としては、Docker 上の format / lint:fix と workflow のログを突き合わせて、workflow 側の pnpm が 10.33.0、ローカル Docker 側が 10.28.0 で一致していなかったことを確認しています。これが「ローカル Docker の lint:fix が workflow で打ち消される」原因候補として一番明確だったので、まずそこを揃えました。
画面スクリーンショット等
URLスクリーンショット
テスト項目
備考