Merged
Conversation
Deploying finansu with
|
| Latest commit: |
3c985e6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8dfe5fc6.finansu.pages.dev |
| Branch Preview URL: | https://fix-wakape-unify-format-rule.finansu.pages.dev |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request downgrades prettier-plugin-tailwindcss from version 0.7.2 to 0.2.8 and migrates the Prettier configuration from package.json to an updated prettier.config.js. These changes result in extensive reformatting of Tailwind CSS class strings across numerous UI components, including adjustments to line breaks and quoting styles. I have no feedback to provide as no review comments were submitted.
…TFes/FinanSu into fix/wakape/unify-format-rules
…tamesu Fix/hikahana/unify format rules tamesu
Wakai111
force-pushed
the
fix/wakape/unify-format-rules
branch
from
e821af2 to
3c985e6
Compare
hikahana
approved these changes
Mar 28, 2026
Collaborator
hikahana
left a comment
hikahana
left a comment
There was a problem hiding this comment.
一旦LGTM
linter変えるとかは別の機会で
| - name: Lint | ||
| working-directory: view/next-project | ||
| run: pnpm run lint:fix | ||
| - uses: stefanzweifel/git-auto-commit-action@v7 |
Collaborator
There was a problem hiding this comment.
このアクション消しちゃうとコミットされなくなっちゃうくない？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
対応Issue
resolve #0
概要
フォーマットルールの統一と自動コミット設定の修正を行いました。
1. Prettier設定の統一
package.json内に記述されていた Prettier の設定を削除し、prettier.config.jsのみしました。prettier.config.jsの内容をpackage.jsonのものに近づけました。eslint.config.mjsにeslint-config-prettierを導入し、ESLintがPrettierのスタイル（クォート等）を上書きしないよう修正しました。2. GitHub Actions (
auto-build.yml) の修正git-auto-commit-actionを削除しました。3. コード整形（ローカルでの実行）
pnpm run formatおよびpnpm run lint:fixをローカル上で実行しました。修正対象ファイル
view/next-project/package.json：重複設定の削除view/next-project/prettier.config.js：ルールの一本化view/next-project/eslint.config.mjs：競合回避設定の追加.github/workflows/auto-build.yml：CIフローの整理view/next-project/pnpm-lock.yaml：依存関係の最適化画面スクリーンショット等
テスト項目
pnpm run formatおよびpnpm run lint:fixが 動作することを確認view/next-projectディレクトリにてpnpm run buildが成功することを確認備考