Skip to content

fix: 協賛活動一覧の協賛スタイル絞り込み時のエラー修正#1071

Merged
TkymHrt merged 1 commit intodevelopfrom
fix/wakape/sponsorship-activity-filter-api
Mar 25, 2026
Merged

fix: 協賛活動一覧の協賛スタイル絞り込み時のエラー修正#1071
TkymHrt merged 1 commit intodevelopfrom
fix/wakape/sponsorship-activity-filter-api

Conversation

@Wakai111
Copy link
Copy Markdown
Collaborator

@Wakai111 Wakai111 commented Mar 25, 2026

対応Issue

概要

協賛活動一覧で「協賛内容(スタイル)」の絞り込みをした際に、協賛内容で絞り込めないバグを修正しました。
原因は sponsorship_activity_repository.go のSQLにおいて、参照するテーブルの指定が抜け落ちていたためです。
該当箇所に .From("activity_sponsor_style_links") を追加しました。

画面スクリーンショット等

テスト項目

  • make build を実行し、ビルドエラーが発生しないこと
  • make run でサーバーが正常に起動すること

備考

他の作業ブランチの動作確認中に見つけたバグの修正です。


Open with Devin

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

このプルリクエストは、協賛活動一覧における「協賛内容(スタイル)」での絞り込み機能が正しく動作しないバグを修正します。SQLクエリのテーブル参照が不足していたことが原因で、この修正によりユーザーは意図した通りに協賛活動を絞り込めるようになり、システムのデータ表示の正確性とユーザビリティが向上します。

Highlights

  • バグ修正: 協賛活動一覧で「協賛内容(スタイル)」による絞り込みが機能しないバグを修正しました。
  • 原因: sponsorship_activity_repository.go 内のSQLクエリで、参照するテーブルの指定が欠落していたことが原因でした。
  • 修正内容: 該当するSQLクエリに .From("activity_sponsor_style_links") を追加し、テーブル参照を明示しました。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot added the bug Something isn't working label Mar 25, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue in the FindAll method of the sponsorshipActivityRepository by adding a missing FROM clause to a subquery. This ensures that sponsorship activities are correctly filtered by sponsor_style_id using the activity_sponsor_style_links table. There are no review comments to address.

@TkymHrt TkymHrt self-requested a review March 25, 2026 10:28
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@TkymHrt TkymHrt merged commit 54d889b into develop Mar 25, 2026
6 checks passed
@TkymHrt TkymHrt deleted the fix/wakape/sponsorship-activity-filter-api branch March 25, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants