Skip to content

[fix] 協賛活動APIのRemarks項目のポインタ型エラーを修正#1067

Merged
Wakai111 merged 1 commit intodevelopfrom
fix/wakape/sponsorship-activity-remarks-pointer
Mar 18, 2026
Merged

[fix] 協賛活動APIのRemarks項目のポインタ型エラーを修正#1067
Wakai111 merged 1 commit intodevelopfrom
fix/wakape/sponsorship-activity-remarks-pointer

Conversation

@Wakai111
Copy link
Copy Markdown
Collaborator

対応Issue

概要

OpenAPIの型移行に伴う、Remarks 項目のポインタ型不一致の修正。

画面スクリーンショット等

テスト項目

  • make build を実行し、ビルドエラーが発生しないこと
  • make run でサーバーが正常に起動すること

備考

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

このプルリクエストは、OpenAPIの型移行によって発生したRemarks項目のポインタ型不一致を修正することを目的としています。これにより、APIの安定性が向上し、意図しないデータ処理が防止されます。

Highlights

  • ポインタ型不一致の修正: sponsorship_activity_usecase.go 内で、Remarks フィールドのポインタ型不一致を修正しました。これにより、*req.Remarks から req.Remarks へと変更され、OpenAPIの型移行に伴う問題を解決します。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot added the bug Something isn't working label Mar 18, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request modifies the UpdateSponsorshipActivityStatus function in sponsorship_activity_usecase.go to correctly assign the Remarks field. Specifically, it removes the dereference operator (*) from req.Remarks when assigning it to activity.Remarks, suggesting that activity.Remarks is now expected to be a pointer type, or req.Remarks is no longer a pointer, ensuring type compatibility and correct handling of the optional field.

Copy link
Copy Markdown
Collaborator

@hikahana hikahana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動作見てないけどLGTM

@Wakai111 Wakai111 merged commit 38fbd20 into develop Mar 18, 2026
5 checks passed
@Wakai111 Wakai111 deleted the fix/wakape/sponsorship-activity-remarks-pointer branch March 18, 2026 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants