Skip to content

Modify action for testing device roles to also fire on changes in deploy_ioc var files#172

Merged
Jakub Wlodek (jwlodek) merged 1 commit intoNSLS2:mainfrom
jwlodek:make-role-tests-run-on-var-changes
Mar 3, 2026
Merged

Modify action for testing device roles to also fire on changes in deploy_ioc var files#172
Jakub Wlodek (jwlodek) merged 1 commit intoNSLS2:mainfrom
jwlodek:make-role-tests-run-on-var-changes

Conversation

@jwlodek
Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings February 13, 2026 14:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions workflow responsible for testing device roles so it also runs when deploy_ioc per-role var files change, ensuring CI coverage for role-affecting configuration updates.

Changes:

  • Renames the workflow and the change-detection step for clearer intent.
  • Extends the pull_request path filters to include roles/deploy_ioc/vars/**.
  • Updates role detection logic to derive impacted device roles from either roles/device_roles/** changes or roles/deploy_ioc/vars/<role>.yml changes.
Comments suppressed due to low confidence (1)

.github/workflows/test-device-roles.yml:52

  • The deploy_ioc/vars case assumes the filename is always the 4th path segment (a[4]). Since the workflow trigger includes roles/deploy_ioc/vars/** (which can include nested subdirectories), any deeper path (e.g., roles/deploy_ioc/vars/subdir/foo.yml) would extract the wrong role name and silently skip testing. Consider extracting the basename from the last path segment (and then stripping the .yml suffix) to make this robust to nesting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jwlodek Jakub Wlodek (jwlodek) merged commit fd6608c into NSLS2:main Mar 3, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants