Modify action for testing device roles to also fire on changes in deploy_ioc var files#172
Merged
Jakub Wlodek (jwlodek) merged 1 commit intoNSLS2:mainfrom Mar 3, 2026
Conversation
…loy_ioc var files
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions workflow responsible for testing device roles so it also runs when deploy_ioc per-role var files change, ensuring CI coverage for role-affecting configuration updates.
Changes:
- Renames the workflow and the change-detection step for clearer intent.
- Extends the
pull_requestpath filters to includeroles/deploy_ioc/vars/**. - Updates role detection logic to derive impacted device roles from either
roles/device_roles/**changes orroles/deploy_ioc/vars/<role>.ymlchanges.
Comments suppressed due to low confidence (1)
.github/workflows/test-device-roles.yml:52
- The
deploy_ioc/varscase assumes the filename is always the 4th path segment (a[4]). Since the workflow trigger includesroles/deploy_ioc/vars/**(which can include nested subdirectories), any deeper path (e.g.,roles/deploy_ioc/vars/subdir/foo.yml) would extract the wrong role name and silently skip testing. Consider extracting the basename from the last path segment (and then stripping the.ymlsuffix) to make this robust to nesting.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Thomas Hopkins (thopkins32)
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.