Open
Conversation
Thomas Hopkins (thopkins32)
changed the title
Copilot started reviewing on behalf of
Thomas Hopkins (thopkins32)
December 22, 2025 14:14
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the pi_e621 role to fix configuration issues and add proper motor substitution handling. The role is being migrated from the hyphenated naming (pi-e621) to underscore naming (pi_e621).
Key changes:
- Restructured motor configuration to use a list-based schema instead of hardcoded environment variables
- Added verification configuration for automated testing
- Separated HOST and HOST_PORT in schema for better validation
Reviewed changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| roles/device_roles/pi_e621/templates/base.cmd.j2 | New template for IOC startup commands with updated variable references |
| roles/device_roles/pi_e621/templates/asyn_motor.substitutions.j2 | Modified to use motor list iteration instead of hardcoded values |
| roles/device_roles/pi_e621/tasks/main.yml | New Ansible tasks for deploying templates |
| roles/device_roles/pi_e621/schema.yml | Updated schema with motor list support and improved HOST validation |
| roles/device_roles/pi_e621/examples/pi-e621-test/verify.yml | New verification configuration with skip_compilation flag |
| roles/device_roles/pi_e621/examples/pi-e621-test/config.yml | Example configuration demonstrating motor list usage |
| roles/device_roles/pi_e621/README.md | Added basic documentation |
| roles/device_roles/pi-e621/* | Removed old hyphenated directory files |
| roles/deploy_ioc/vars/pi_e621.yml | New deployment variables for the role |
| .github/workflows/test-roles.yml | Comment clarification about excluding deleted roles |
Comments suppressed due to low confidence (1)
roles/device_roles/pi_e621/schema.yml:49
- The motor schema defines fields (egu, twv, velo, vbas, accl, bdst, bvel, bacc, mres, prec, dhlm, dllm, init) that are not referenced in the asyn_motor.substitutions.j2 template. The template uses hardcoded environment variable references like "$(EGU)", "$(TWV)", etc. instead of motor.egu, motor.twv, etc. Either remove these unused schema fields or update the template to use per-motor values.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Jakub Wlodek (jwlodek)
requested changes
Dec 22, 2025
Co-authored-by: Jakub Wlodek <jwlodek@bnl.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.