Modifications to support newer version of ADPhantom driver#122
Merged
Thomas Hopkins (thopkins32) merged 9 commits intoNSLS2:mainfrom Nov 7, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ADPhantom device role configuration to use new API functions and parameters. The changes migrate from deprecated "miro" naming to "ADPhantom" naming conventions and add support for MAC address and network interface configuration.
- Updates template to use standardized variable names (
deploy_ioc_template_root_path,deploy_ioc_executable) - Replaces deprecated miro* function calls with ADPhantom* equivalents
- Adds MAC_ADDR and INTF environment variables for network configuration
- Reorganizes set_requestfile_path command to the beginning of the file
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| roles/device_roles/adphantom/templates/base.cmd.j2 | Updates variable names, replaces miro* functions with ADPhantom*, adds MAC_ADDR and INTF parameters to ADPhantomConfig, and reorganizes set_requestfile_path |
| roles/device_roles/adphantom/schema.yml | Adds MAC_ADDR and INTF as required environment variables |
| roles/device_roles/adphantom/example.yml | Provides example values for new MAC_ADDR and INTF environment variables |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Jakub Wlodek (jwlodek)
requested review from
Jennefer Maldonado (jennmald) and
Thomas Hopkins (thopkins32)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note, for now pointed this at my fork, pending DiamondLightSource/ADPhantom#24