Conversation
Member
Author
|
@copilot Please finish the remaining two points in the PR description. |
htsnowden
approved these changes
Mar 4, 2026
Contributor
htsnowden
left a comment
There was a problem hiding this comment.
This seems like cool functionality. It seems like you have made a new model. Do you also want to embed current models to allow for the interface to work on all current models?
Member
Author
|
Yep, the PR includes conversion in both directions, so anything Classical now also has compatibility with AtomsCalculators.jl / AtomsBase. I didn't do this for QuantumModels because I'm not aware of a standard for how to return multi-state energies and forces, but you could get single states from a QuantumModel with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JuliaMolSim has built a Calculator framework to work with AtomsBase and similar packages. We should be able to convert back and forth between the two.
AtomsCalculatorsinterface for allNQCModels.ClassicalModeltypes.