Open
Conversation
| struct JuLIPModel{T} <: AdiabaticModel | ||
| struct JuLIPModel{T,M} <: AdiabaticModel | ||
| atoms::JuLIP.Atoms{T} | ||
| constr::Matrix{M} |
Member
There was a problem hiding this comment.
Probably it is fine here to require that the type parameter T of the atoms is the same as that for the matrix. Or if the constraints matrix is supposed to always contain ones and zeros I would suggest using Matrix{Int} instead.
jamesgardner1421
requested changes
Nov 19, 2023
Comment on lines
-82
to
+83
| model = AdiabaticModels.JuLIPModel(at) | ||
| incl = ones(1,length(at)) | ||
| model = AdiabaticModels.JuLIPModel(at,incl) |
Member
There was a problem hiding this comment.
Instead of changing the test. I would add a constructor where the second argument defaults to ones for all degrees of freedom. In the unlikely event that anyone else is using this will ensure their code doesn't break.
Member
|
@wgst this looks rather old. Are these commits still relevant? If so, would you mind getting these ready for merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.