Updating Yadism for Python 3.13#340
Merged
felixhekhorn merged 15 commits intomasterfrom Jan 15, 2026
Merged
Conversation
felixhekhorn
changed the title
scarlehoff
reviewed
Jan 13, 2026
Contributor
|
let's not abuse the code review for unrelated things 🙈 please close the conversations, when they are addressed. That being said I can reproduce the error locally for 3.12 - I'll try to see if I can find out something |
Contributor
|
@jekoorn I managed to make the unit tests running following your route, but more strictly. Please run pre-commit on the remaining file (I've done it mostly for you 🙃 ) and then I think we can merge |
scarlehoff
reviewed
Jan 15, 2026
Contributor
Author
|
@felixhekhorn thanks for looking into it - pre-commit is done. |
felixhekhorn
approved these changes
Jan 15, 2026
Member
|
As this been tested with pinefarm to check that it also works in real-life? |
Closed
Contributor
Author
Not yet, no. I haven't run pinefarm yet before with yadism, so I will need to look into how this works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.