Skip to content

Add manual PartialEq for Interp #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cschwan merged 5 commits into from
Dec 6, 2025
Merged

Add manual PartialEq for Interp #367

cschwan merged 5 commits into from
Dec 6, 2025

Conversation

@Radonirinaunimi
Copy link
Member

@Radonirinaunimi Radonirinaunimi commented Nov 26, 2025

Addresses #366.

felixhekhorn
felixhekhorn approved these changes Nov 26, 2025
View reviewed changes
Copy link
Contributor

@felixhekhorn felixhekhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this fix the evolution does no longer crash with Error: interpolations do not match (I'm not sure which PDF the EKO corresponds to so I'm happy with a Error: grids are different)

@felixhekhorn felixhekhorn linked an issue Nov 26, 2025 that may be closed by this pull request
Evolution results in "interpolations do not match" #366
Closed
@cschwan
Copy link
Contributor

cschwan commented Nov 26, 2025

@Radonirinaunimi: can you please write a regression test where one of the fields is a NaN?

@Radonirinaunimi
Copy link
Member Author

Radonirinaunimi commented Nov 26, 2025

@Radonirinaunimi: can you please write a regression test where one of the fields is a NaN?

Good point! I just added a simple unit test.

@Radonirinaunimi
Copy link
Member Author

Radonirinaunimi commented Nov 27, 2025

@cschwan Are you happy with this?

cschwan
cschwan requested changes Nov 29, 2025
View reviewed changes
felixhekhorn
felixhekhorn reviewed Dec 1, 2025
View reviewed changes
@Radonirinaunimi Radonirinaunimi mentioned this pull request Dec 3, 2025
Open
1 task
@Radonirinaunimi
Copy link
Member Author

Radonirinaunimi commented Dec 4, 2025

I was thinking of updating the CHANGELOGS in master but I guess it could also be done here (ce3902f).

@cschwan
Copy link
Contributor

cschwan commented Dec 6, 2025

I was thinking of updating the CHANGELOGS in master but I guess it could also be done here (ce3902f).

That was the right idea, I simply didn't express myself properly. In any case, thank you! 👍

@cschwan cschwan merged commit ed46cd9 into master Dec 6, 2025
10 checks passed
@cschwan cschwan deleted the fix-interp-comp branch December 6, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cschwan cschwan cschwan requested changes

@felixhekhorn felixhekhorn felixhekhorn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Evolution results in "interpolations do not match"

4 participants

@Radonirinaunimi @cschwan @felixhekhorn