SPINEDEM-5254 Enforce app-specific rate limits in INT#1144
SPINEDEM-5254 Enforce app-specific rate limits in INT#1144davidhamill1-nhs wants to merge 24 commits intomasterfrom
Conversation
|
This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket: SPINEDEM-5254 |
|
This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket: SPINEDEM-5254 |
|
This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket: SPINEDEM-5254 |
|
This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket: SPINEDEM-5254 |
|
This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket: SPINEDEM-5254 |
|
This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket: SPINEDEM-5254 |
|
This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket: SPINEDEM-5254 |
dlzhry2nhs
left a comment
dlzhry2nhs
left a comment
There was a problem hiding this comment.
Just a couple of general comments added. I'm not particularly familiar with this area so might be worth also getting a review from someone more familiar with karate and rate limits.
...te-tests/src/test/java/patients/rateLimits/getPatientDetails/getPatientForDefaultApp.feature
Outdated
Show resolved
Hide resolved
...te-tests/src/test/java/patients/rateLimits/getPatientDetails/getPatientForDefaultApp.feature
Show resolved
Hide resolved
karate-tests/src/test/java/patients/rateLimits/rateLimitAppSimulation.scala
Outdated
Show resolved
Hide resolved
karate-tests/src/test/java/patients/rateLimits/rateLimitAppSimulation.scala
Outdated
Show resolved
Hide resolved
karate-tests/src/test/java/patients/rateLimits/tripAppRateLimits.feature
Outdated
Show resolved
Hide resolved
karate-tests/src/test/java/patients/rateLimits/tripAppRateLimits.feature
Outdated
Show resolved
Hide resolved
dlzhry2nhs
left a comment
dlzhry2nhs
left a comment
There was a problem hiding this comment.
Additionally, it might be good to mention which env vars are missing. At first I was missing
PROXY_RATE_LIMITING_APP_CLIENT_ID
and
RATE_LIMITING_APP_CLIENT_ID
But now I'm running into an issue where is states that no API product was found. Might be helpful to know what is needed to run the tests - either in the README or in Confluence.
The reference env file has been updated in Confluence so that the dev team can easily run the test suite. |
This reverts commit a13532f.
…ate-limit-tests-int' into SPINEDEM-5254-add-rate-limit-tests-int
|
4 participants
Summary
Add any other relevant notes or explanations here. Remove this line if you have nothing to add.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.