SPINEDEM-3983 Improve documentation for period#1108
Open
davidhamill1-nhs wants to merge 5 commits intomasterfrom
Open
SPINEDEM-3983 Improve documentation for period#1108davidhamill1-nhs wants to merge 5 commits intomasterfrom
davidhamill1-nhs wants to merge 5 commits intomasterfrom
Conversation
|
This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket: SPINEDEM-3983 |
With the removal of period as an object in Patient.contact, `period` cannot be deleted as it does not exist.
|
This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket: SPINEDEM-3983 |
|
This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket: SPINEDEM-3983 |
Checking the commitId in the status response will ensure we have the correct version of the sandbox deployed. This will also help with changes to the sandbox response.
|
This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket: SPINEDEM-3983 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The documentation for period is at best unclear and at worst contradictory.
This should bring both clarity and accuracy.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.