Skip to content

[PRM-691] Removal v in aws cred version and use env tag #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliverbeumkes-nhs merged 4 commits into from
Mar 17, 2026
Merged

[PRM-691] Removal v in aws cred version and use env tag #295

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7c2809
[PRM-691] Removal of rogue v infront of version
oliverbeumkes-nhs Mar 17, 2026
ddf30d2
Use env tag not inputs.tag
oliverbeumkes-nhs Mar 17, 2026
8e6c0c2
Give contents write for creating tags
oliverbeumkes-nhs Mar 17, 2026
39a2aea
Remove pull-request write permissions
oliverbeumkes-nhs Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/workflows/tool-create-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,19 @@ jobs:
create_release:
name: Create Release
runs-on: ubuntu-latest
env:
tag: ${{ inputs.tag }}
steps:
- name: Validate Tag Format
run: |
if [[ ! "${{ github.event.inputs.tag }}" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
if [[ ! "$tag" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
echo "Error: Tag must be in the format X.Y.Z (e.g. 1.0.0)"
exit 1
fi

- name: Configure AWS Credentials
id: credentials
uses: aws-actions/configure-aws-credentials@v8df5847569e6427dd6c4fb1cf565c83acfa8afa7 # v6.0.0
uses: aws-actions/configure-aws-credentials@8df5847569e6427dd6c4fb1cf565c83acfa8afa7 # v6.0.0
with:
role-to-assume: ${{ secrets.IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
Expand All @@ -42,8 +44,8 @@ jobs:
run: |
git config --global user.name "github-actions"
git config --global user.email "github@github.com"
git tag ${{ github.event.inputs.tag }}
git push origin ${{ github.event.inputs.tag }}
git tag $tag
git push origin $tag

- name: Full Deployment
uses: ./.github/workflows/full-deployment.yml
Expand All @@ -55,7 +57,6 @@ jobs:
- name: Re-tag ECR Images with Release Tag
env:
IMAGE_SHA: ${{ github.sha }}
IMAGE_TAG: ${{ inputs.tag }}
run: |
repo-list=['deductions/ehr-out-service',
'deductions/ehr-repo',
Expand All @@ -69,8 +70,8 @@ jobs:
for repo in "${repo-list[@]}"; do
repo=${{ steps.credentials.outputs.aws-account-id }}.dkr.ecr.eu-west-2.amazonaws.com/$repo
docker pull $repo:$IMAGE_SHA
docker tag $repo:$IMAGE_SHA $repo:$IMAGE_TAG
docker push $repo:$IMAGE_TAG
docker tag $repo:$IMAGE_SHA $repo:$tag
docker push $repo:$tag
done


Loading