NCRS-3732 Warning Icon improvements#42
Merged
CalMitchellBJSS merged 3 commits intomainfrom Jul 8, 2025
Merged
Conversation
…ent and added aria-label
alice-bell
previously approved these changes
Jul 8, 2025
Contributor
alice-bell
left a comment
alice-bell
left a comment
There was a problem hiding this comment.
Looks good, I've pulled the code and played around with it locally. (There's a pipeline failure on the Storybook build, but that is currently happening to every branch and is unconnected to the Storybook changes in this branch.)
|
alice-bell
approved these changes
Jul 8, 2025
Contributor
alice-bell
left a comment
alice-bell
left a comment
There was a problem hiding this comment.
Re-approving after the package.json version bump
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the warning icon be able to be monochrome and transparent and added aria-label. Removed unnecessary groups and translates.