Skip to content

CCM-14753: approve letter#880

Open
alexnuttall wants to merge 38 commits intofeature/CCM-14190_choose-printing-and-postagefrom
feature/CCM-14753-approve-letter
Open

CCM-14753: approve letter#880
alexnuttall wants to merge 38 commits intofeature/CCM-14190_choose-printing-and-postagefrom
feature/CCM-14753-approve-letter

Conversation

@alexnuttall
Copy link
Contributor

@alexnuttall alexnuttall commented Mar 17, 2026

Description

Screenshot 2026-03-18 at 13-54-23 Review and approve letter template - NHS Notify

Adds an approval endpoint and the review-and-approve-letter-template page.

The API route fetches the template first, in order to get the letter variant ID, then the letter variant. The letter variant's maxSheets value must be known to validate the renders before submission. Validation is done against the fetched template rather than in the typical way, in a conditional update. The conditional update itself only uses lockNumber.

Other changes

  • Remove an undefined style on details component headings (styles.preview__heading)
  • Add proper 'open in new tab' behaviour to a link on the authoring letter preview page

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@alexnuttall alexnuttall requested review from a team as code owners March 17, 2026 09:25
@alexnuttall alexnuttall marked this pull request as draft March 17, 2026 09:25
@alexnuttall alexnuttall added the skip-trivy-package Skip the Trivy Package Scan label Mar 17, 2026
@alexnuttall alexnuttall removed request for a team March 17, 2026 15:03
@alexnuttall alexnuttall marked this pull request as ready for review March 18, 2026 13:46
@alexnuttall alexnuttall changed the title Draft: CCM-14753: approve letter CCM-14753: approve letter Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-trivy-package Skip the Trivy Package Scan

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants