Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes/disabled Trivy (and previously tfsec-based) Terraform IaC security scanning from local make targets and the “Commit stage” GitHub Actions workflow, with TODOs to revisit tooling later.
Changes:
- Removed the
terraform-secmake target implementation (previously runningtfsec) and replaced it with commented TODOs. - Commented out the
trivyentry in.tool-versions. - Deleted the Trivy scan job from
.github/workflows/stage-1-commit.yaml.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/terraform/terraform.mk | Removes the terraform-sec quality target implementation and leaves TODO/commented guidance. |
| .tool-versions | Comments out the Trivy tool pin and adds a TODO to revisit usage. |
| .github/workflows/stage-1-commit.yaml | Removes the Trivy scanning job from the commit-stage workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sidnhs
approved these changes
Mar 24, 2026
aidenvaines-cgi
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.