Skip to content

Feature/ccm 15186 queue metrics#462

Open
stevebux wants to merge 1 commit intofeature/CCM-13906-Urgent-Letter-Priorityfrom
feature/CCM-15186-Queue-Metrics
Open

Feature/ccm 15186 queue metrics#462
stevebux wants to merge 1 commit intofeature/CCM-13906-Urgent-Letter-Priorityfrom
feature/CCM-15186-Queue-Metrics

Conversation

@stevebux
Copy link
Contributor

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

This comment was marked as outdated.

@stevebux stevebux changed the base branch from main to feature/CCM-13116-Letter-Queue-Operations March 17, 2026 16:16
@stevebux stevebux changed the base branch from feature/CCM-13116-Letter-Queue-Operations to feature/CCM-13906-Urgent-Letter-Priority March 17, 2026 16:17
@stevebux stevebux requested a review from Copilot March 17, 2026 16:18
@stevebux stevebux removed the request for review from a team March 17, 2026 16:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces queue-size delta metrics for the update-letter-queue Lambda (used to maintain the pending letters queue table from the letters change stream), alongside dependency/lockfile updates.

Changes:

  • Emit CloudWatch EMF metrics for per-supplier pending-queue deltas (QueueDelta) from update-letter-queue.
  • Refactor queue update helpers to return numeric deltas (0/1) and aggregate per supplier across a batch.
  • Update dependency locks/overrides (npm overrides for flatted/undici, and bump pyjwt in e2e Poetry lock).

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/e2e-tests/poetry.lock Updates locked pyjwt version for e2e test environment.
package.json Adds npm overrides entries for flatted and undici.
package-lock.json Updates resolved versions for flatted/undici per overrides.
lambdas/update-letter-queue/src/update-letter-queue.ts Adds per-supplier queue delta metric aggregation and emission.
lambdas/update-letter-queue/src/tests/update-letter-queue.test.ts Updates/extends unit tests to assert QueueDelta metric behavior and new edge-case handling.

You can also share your feedback on Copilot code review. Take the survey.

@stevebux stevebux force-pushed the feature/CCM-13906-Urgent-Letter-Priority branch from 6c44dc5 to a777277 Compare March 19, 2026 14:29
@stevebux stevebux force-pushed the feature/CCM-15186-Queue-Metrics branch from a720039 to e1f2e62 Compare March 19, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants