Feature/CCM-10257 implement eventpub in core#81
Merged
jamesthompson26-nhs merged 2 commits intomainfrom Jun 9, 2025
Merged
Conversation
jamesthompson26-nhs
requested review from
RossBugginsNHS,
aidenvaines-cgi,
m-houston and
timireland
as code owners
aidenvaines-cgi
previously approved these changes
Jun 3, 2025
sidnhs
reviewed
Jun 3, 2025
sidnhs
reviewed
Jun 3, 2025
aidenvaines-cgi
previously approved these changes
Jun 4, 2025
sidnhs
previously approved these changes
Jun 4, 2025
jamesthompson26-nhs
dismissed stale reviews from sidnhs and aidenvaines-cgi
via
16d0231
jamesthompson26-nhs
force-pushed
the
feature/CCM-10257_Implement_Eventpub_in_Core
branch
from
16d0231 to
89f4a0a
Compare
aidenvaines-cgi
changed the title
aidenvaines-cgi
approved these changes
Jun 9, 2025
jamesthompson26-nhs
deleted the
feature/CCM-10257_Implement_Eventpub_in_Core
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes required for the deployment into Core.
Permissions boundary needed in core to allow CreateRole actions. Still optional but available as needed.
'RELIABILITY:' added as prefix to alarm descriptions to ensure they're picked up by the event rule in core and thus forwarded to teams. Also added an SNS delivery failure alarm as per Tom's question in:
https://nhsd-jira.digital.nhs.uk/browse/CCM-10257
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.