Skip to content

CCM-17036: Fix Pre Commit Hook Args#184

Merged
jamesthompson26-nhs merged 1 commit intomainfrom
feature/CCM-17036_Fix_Pre_Commit_Hook_Args
Apr 24, 2026
Merged

CCM-17036: Fix Pre Commit Hook Args#184
jamesthompson26-nhs merged 1 commit intomainfrom
feature/CCM-17036_Fix_Pre_Commit_Hook_Args

Conversation

@jamesthompson26-nhs
Copy link
Copy Markdown
Contributor

@jamesthompson26-nhs jamesthompson26-nhs commented Apr 23, 2026

Description

Shared githook scripts now parse and convert positional args to env vars. Remote repos sourcing and running the pre-commits use 'arg:' in the pre-commit.yaml which resolve as positional args.

Context

Currently shared githooks are being run without the provided args so with default values.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@jamesthompson26-nhs jamesthompson26-nhs requested a review from a team as a code owner April 23, 2026 14:21
Comment thread .github/actions/check-file-format/check-file-format.sh
@jamesthompson26-nhs jamesthompson26-nhs merged commit 6ae325a into main Apr 24, 2026
45 checks passed
@jamesthompson26-nhs jamesthompson26-nhs deleted the feature/CCM-17036_Fix_Pre_Commit_Hook_Args branch April 24, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants