Skip to content

CCM-16484: Improve lambda_env_vars output#173

Merged
jamesthompson26-nhs merged 1 commit intomainfrom
feature/CCM-16484_Improve_Lambda_Env_Vars_Output
Apr 9, 2026
Merged

CCM-16484: Improve lambda_env_vars output#173
jamesthompson26-nhs merged 1 commit intomainfrom
feature/CCM-16484_Improve_Lambda_Env_Vars_Output

Conversation

@jamesthompson26-nhs
Copy link
Copy Markdown
Contributor

@jamesthompson26-nhs jamesthompson26-nhs commented Apr 8, 2026

Description

Simplify the lambda_env_vars output to make it less defensive.

Context

Though it looks more safe and defensive, where the module calls insert something into the variable that cannot be resolved at plan time (Skynet hit this with s3bucket.this.id) it can cause the plan to fail.

Deployed to sbx env in template management, using this branch to modify the source of 33 lambdas in the backend-api module:

#173
https://github.com/NHSDigital/nhs-notify-internal/actions/runs/24185496908

Deploys successfully and all tests pass/

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@jamesthompson26-nhs jamesthompson26-nhs merged commit 2e0290a into main Apr 9, 2026
45 checks passed
@jamesthompson26-nhs jamesthompson26-nhs deleted the feature/CCM-16484_Improve_Lambda_Env_Vars_Output branch April 9, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants