CCM-16484: Improve lambda_env_vars output#173
Merged
jamesthompson26-nhs merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
sidnhs
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplify the
lambda_env_varsoutput to make it less defensive.Context
Though it looks more safe and defensive, where the module calls insert something into the variable that cannot be resolved at plan time (Skynet hit this with s3bucket.this.id) it can cause the plan to fail.
Deployed to sbx env in template management, using this branch to modify the source of 33 lambdas in the backend-api module:
#173
https://github.com/NHSDigital/nhs-notify-internal/actions/runs/24185496908
Deploys successfully and all tests pass/
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.