Skip to content

CCM-12958: Additional policies for eventcache bucket in eventpub #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sidnhs merged 2 commits into from
Feb 9, 2026
Merged

CCM-12958: Additional policies for eventcache bucket in eventpub #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dad2b2e
CCM-12958: Additional policies for eventcache bucket in eventpub
sidnhs Feb 9, 2026
6ec15d9
CCM-12958: Additional policies for eventcache bucket in eventpub
sidnhs Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion infrastructure/modules/eventpub/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

| Name | Description | Type | Default | Required |
|------|-------------|------|---------|:--------:|
| <a name="input_additional_policies_for_event_cache_bucket"></a> [additional\_policies\_for\_event\_cache\_bucket](#input\_additional\_policies\_for\_event\_cache\_bucket) | A list of JSON policies to use to build the bucket policy | `list(string)` | `[]` | no |
| <a name="input_aws_account_id"></a> [aws\_account\_id](#input\_aws\_account\_id) | The AWS Account ID (numeric) | `string` | n/a | yes |
| <a name="input_component"></a> [component](#input\_component) | The name of the terraformscaffold component calling this module | `string` | n/a | yes |
| <a name="input_control_plane_bus_arn"></a> [control\_plane\_bus\_arn](#input\_control\_plane\_bus\_arn) | Data plane event bus arn | `string` | n/a | yes |
Expand All @@ -36,7 +37,7 @@

| Name | Source | Version |
|------|--------|---------|
| <a name="module_s3bucket_event_cache"></a> [s3bucket\_event\_cache](#module\_s3bucket\_event\_cache) | git::https://github.com/NHSDigital/nhs-notify-shared-modules.git//infrastructure/modules/s3bucket | v1.0.8 |
| <a name="module_s3bucket_event_cache"></a> [s3bucket\_event\_cache](#module\_s3bucket\_event\_cache) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.30/terraform-s3bucket.zip | n/a |
## Outputs

| Name | Description |
Expand Down
9 changes: 5 additions & 4 deletions infrastructure/modules/eventpub/module_s3bucket_event_cache.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module "s3bucket_event_cache" {
source = "git::https://github.com/NHSDigital/nhs-notify-shared-modules.git//infrastructure/modules/s3bucket?ref=v1.0.8"
source = "https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.30/terraform-s3bucket.zip"

count = var.enable_event_cache ? 1 : 0

Expand Down Expand Up @@ -36,9 +36,10 @@ module "s3bucket_event_cache" {
}
]

policy_documents = [
data.aws_iam_policy_document.s3bucket_event_cache[0].json
]
policy_documents = concat(
[data.aws_iam_policy_document.s3bucket_event_cache[0].json],
var.additional_policies_for_event_cache_bucket
)

public_access = {
block_public_acls = true
Expand Down
6 changes: 6 additions & 0 deletions infrastructure/modules/eventpub/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,3 +123,9 @@ variable "force_destroy" {
description = "When enabled will force destroy event-cache S3 bucket"
default = false
}

variable "additional_policies_for_event_cache_bucket" {
type = list(string)
description = "A list of JSON policies to use to build the bucket policy"
default = []
}
Loading