APPT-1570/1387 - Removing the cancel and change session uplift journey feature flags

[ste-banks]

Description

• Removing the cancel session uplift and the change session uplift journey feature flags
• Updating integration tests so they not longer use the feature toggle steps
• Fixing unit tests / integration tests / e2e tests where applicable
• Removing them both from each environment's feature flags json files

Fixes # (issue)

Checklist:

• My work is behind a feature toggle (if appropriate)
• If my work is behind a feature toggle, I've added a full suite of tests for both the ON and OFF state
• The ticket number is in the Pull Request title, with format "APPT-XXX: My Title Here"
• I have ran npm tsc / lint (in the future these will be ran automatically)
• My code generates no new .NET warnings (in the future these will be treated as errors)
• If I've added a new Function, it is disabled in all but one of the terraform groups (e.g. http_functions)
• If I've added a new Function, it has both unit and integration tests. Any request body validators have unit tests also
• If I've made UI changes, I've added appropriate Playwright and Jest tests
• If I've added/updated an end-point, I've added the appropriate annotations and tested the Swagger documentation reflects the change

[jsed-nhs]

Have you double checked all the Integration test 'disabled' files are covered in the 'enabled' tests retained (i.e where behaviour is the same for a flag disabled/enabled, that the test exists in the enabled file?) - if some are missing, this will have missed off by another dev, but always worth carefully checking when removing the disabled tests.

[ste-banks]

Have you double checked all the Integration test 'disabled' files are covered in the 'enabled' tests retained (i.e where behaviour is the same for a flag disabled/enabled, that the test exists in the enabled file?) - if some are missing, this will have missed off by another dev, but always worth carefully checking when removing the disabled tests.

Yeah I had a scan through before deleting them and for these the disabled files only contained tests which ensured the endpoints returned a 501 if the flag was disabled, which obviously is no longer relevant with them being removed :)

[sonarqubecloud]

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
67.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud