Open
Conversation
jameslinnell
had a problem deploying
to
development
GitHub Actions
Failure
Code security issues foundView full details here. |
|
| search_condition = [nhs_number, document_key] | ||
| if len(documents) > 1: | ||
| logger.warning( | ||
| f"Multiple documents found for key {document_key}, using first one", |
Contributor
There was a problem hiding this comment.
is there anything more identifiable that could be added to the log to help pinpoint which one is used?
Contributor
Author
There was a problem hiding this comment.
This is only used during a LG request. It's moved from line 136. I'm reluctant to change log messages that are associated with LG
matthewpotter2-nhs
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Jira ticket: NDR-436
Description
Set CORE table to use ID as it's PK
Context
Checklist
Tasks for all changes:
Deploy - SandboxSANDBOX Full- Deploy feature branch to sandbox