[NDR-423] CORE DB to use ID, all endpoints ignore SNOMED code#1151

Open

jameslinnell wants to merge 28 commits intomainfrom

Contributor

jameslinnell commented Mar 4, 2026

Overview

Jira ticket: NDR-423

Description

Changes CORE db calls to use the updated DB design. All FHIR endpoints now longer require snomed code as part of their request

Context

SNOMED is a redundant parameter, IDs were previously not FHIR compliant.

Checklist

Tasks for all changes:

1. I have linked this PR to its Jira ticket.
2. I have run git pre-commits.
3. I have added and/or updated relevant tests.
4. I have updated relevant documentation.
5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary).
6. I have successfully deployed this change to a sandbox and witnessed unit, e2e and smoke tests passing:
- 6a. Deploy - Sandbox
- 6b. SANDBOX Full- Deploy feature branch to sandbox

jameslinnell requested review from a team as code owners

March 4, 2026 14:00

jameslinnell requested a review from AndyFlintAnswerDigital

March 4, 2026 14:00

jameslinnell had a problem deploying to development

March 4, 2026 14:00

— with

GitHub Actions Failure

jameslinnell force-pushed the NDR-423 branch from 61afa8a to 6113c56 Compare

March 4, 2026 14:01

jameslinnell had a problem deploying to development

March 4, 2026 14:01

— with

GitHub Actions Failure

jameslinnell had a problem deploying to development

March 4, 2026 14:11

— with

GitHub Actions Failure

megan-bower4 reviewed

View reviewed changes

lambdas/handlers/get_fhir_document_reference_handler.py Outdated Show resolved Hide resolved

megan-bower4 reviewed

View reviewed changes

lambdas/handlers/get_fhir_document_reference_handler.py Show resolved Hide resolved

megan-bower4 reviewed

View reviewed changes

lambdas/services/document_service.py Show resolved Hide resolved

megan-bower4 reviewed

View reviewed changes

lambdas/services/document_service.py Show resolved Hide resolved

megan-bower4 reviewed

View reviewed changes

lambdas/services/get_fhir_document_reference_service.py Outdated Show resolved Hide resolved

megan-bower4 reviewed

View reviewed changes

lambdas/services/upload_document_reference_service.py Show resolved Hide resolved

megan-bower4 reviewed

View reviewed changes

lambdas/services/upload_document_reference_service.py Show resolved Hide resolved

megan-bower4 reviewed

View reviewed changes

lambdas/tests/e2e/api/fhir/test_mtls_api_failure.py Outdated Show resolved Hide resolved

megan-bower4 reviewed

View reviewed changes

lambdas/tests/e2e/api/fhir/test_retrieve_document_fhir_api_failure.py Show resolved Hide resolved

megan-bower4 reviewed

View reviewed changes

lambdas/tests/e2e/api/fhir/test_retrieve_document_fhir_api_failure.py Show resolved Hide resolved

megan-bower4 reviewed

View reviewed changes

lambdas/tests/e2e/helpers/data_helper.py Show resolved Hide resolved

megan-bower4 reviewed

View reviewed changes

lambdas/tests/unit/handlers/test_get_fhir_document_reference_handler.py Show resolved Hide resolved

megan-bower4 reviewed

View reviewed changes

lambdas/tests/unit/services/test_pdm_get_fhir_document_reference_by_id_service.py Outdated Show resolved Hide resolved

jameslinnell force-pushed the NDR-423 branch from acb8e13 to d11cf68 Compare

March 12, 2026 10:11

jameslinnell temporarily deployed to development

March 12, 2026 10:11

— with

GitHub Actions Inactive

jameslinnell temporarily deployed to development

March 12, 2026 10:21

— with

GitHub Actions Inactive

jameslinnell temporarily deployed to development

March 12, 2026 10:45

— with

GitHub Actions Inactive

megan-bower4 reviewed

View reviewed changes

lambdas/tests/e2e/api/fhir/test_search_patient_fhir_api.py Outdated Show resolved Hide resolved

jameslinnell temporarily deployed to development

March 12, 2026 11:10

— with

GitHub Actions Inactive

jameslinnell force-pushed the NDR-423 branch from de1a4d0 to d44a74b Compare

March 12, 2026 14:00

jameslinnell temporarily deployed to development

March 12, 2026 14:00

— with

GitHub Actions Inactive

jameslinnell temporarily deployed to development

March 12, 2026 14:28

— with

GitHub Actions Inactive

jameslinnell added 23 commits

March 16, 2026 10:26


          [NDR-423] Don't return deleted items on get_item

460daa1


          [NDR-423] Search tests

e167ce0


          [NDR-423] Docker fix

dcc71b0


          [NDR-423] Update unit tests

b73c3cf


          [NDR-423] upload service now checks PDM by ID

edd2b74


          [NDR-423] LG FHIR E2E tests fix


          [NDR-423] Update file update

6bb66a2


          [NDR-423] Fix upload test

d470b62


          [NDR-423] LG FHIR test

16290a3


          [NDR-423] Removed now broken 500 error

cd95937


          [NDR-423] Update tests

c83c138


          [NDR-423] Update tests

0108a21


          [NDR-423] Fix DocStatus tests

53d05cf


          [NDR-423] Update DocStatus

c9c37af


          [NDR-423] Remove print

864f335


          [NDR-423] PR changes

2c7f8ea


          [NDR-423] PR changes


          [NDR-423] Small change

fb2e159


          [NDR-423] Fix search tests

f8f044d


          [NDR-423] Search fix

870d820


          [NDR-423] Fix e2e test help message

1f0c842


          [NDR-423] Remove search test file that has been renamed in a previous PR

9f3826c


          [NDR-423] Removed MTLS 500 error test

74783a8

jameslinnell force-pushed the NDR-423 branch from b951e08 to 74783a8 Compare

March 16, 2026 10:26

jameslinnell had a problem deploying to development

March 16, 2026 10:28

— with

GitHub Actions Failure


          [NDR-423] Still return SNOMED

11317fd

jameslinnell dismissed megan-bower4’s stale review via

11317fd

March 16, 2026 14:00

jameslinnell had a problem deploying to development

March 16, 2026 14:00

— with

GitHub Actions Failure

github-actions bot commented Mar 16, 2026

Code security issues found

View full details here.

sonarqubecloud bot commented Mar 16, 2026

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet