Do not consume placeholder imms api values#6363
Merged
Conversation
jf-x-dev
force-pushed
the
do-not-consume-placeholder-imms-api-values
branch
3 times, most recently
from
f61ca3a to
2137501
Compare
thomasleese
reviewed
Mar 23, 2026
jf-x-dev
force-pushed
the
do-not-consume-placeholder-imms-api-values
branch
3 times, most recently
from
8194491 to
09e1732
Compare
thomasleese
approved these changes
Mar 23, 2026
* Sets the performed_ods_code to nil instead Jira-Issue: MAV-4095
* Many records have a placeholder expiry date of 9999-12-31 * There may be other placeholders that we have not seen yet * We'll only store the date if it has a realistic expiry date
* Continue filling the location name with the location code if it is not a placeholder but Mavis doesn't recognize it Jira-Issue: MAV-4095
jf-x-dev
force-pushed
the
do-not-consume-placeholder-imms-api-values
branch
from
09e1732 to
4488f88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Imms API records have placeholder values which would not be worth consuming. For example, some records have an expiry date of
9999-12-31or a URN/ODS code ofX99999. This information is not useful and it is probably better for users if we leave these fields asnilin these cases.Jira-Issue: MAV-4095