Merged
Conversation
zoltan-antal
force-pushed
the
e2e-tests-on-fork-pr
branch
15 times, most recently
from
78bfc8d to
49008d7
Compare
Contributor
Author
|
I'm open to suggestions for better workflow names. |
thomasleese
reviewed
Mar 20, 2026
Contributor
thomasleese
left a comment
thomasleese
left a comment
There was a problem hiding this comment.
I'm open to suggestions for better workflow names.
The names of these workflows and tests are getting quite long, which is making it difficult to see at a glance which step is which:
I think we can simplify and make these less wordy, perhaps something like:
End-to-end tests / Local / end-to-end-tests
End-to-end tests / Deployed / build-and-push-database-image
End-to-end tests / Deployed / launch-dockerized-image
...
Contributor
Author
|
zoltan-antal
force-pushed
the
e2e-tests-on-fork-pr
branch
6 times, most recently
from
242fbc2 to
e24f4ac
Compare
Contributor
Author
|
We'll need to change the branch protection rules to be able to merge this. |
zoltan-antal
force-pushed
the
e2e-tests-on-fork-pr
branch
9 times, most recently
from
c82a269 to
41b4b2d
Compare
TheOneFromNorway
approved these changes
Mar 31, 2026
zoltan-antal
force-pushed
the
e2e-tests-on-fork-pr
branch
4 times, most recently
from
19ed133 to
19598d6
Compare
Add new workflow which calls tests locally. Update existing AWS workflow to be called instead of automatically triggering on PR. Add entrypoint workflow for deciding whether AWS or local test workflow should run. Rename workflows and simplify names.
zoltan-antal
force-pushed
the
e2e-tests-on-fork-pr
branch
from
19598d6 to
eb43b37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow running E2E tests on fork PRs
Add new workflow which calls tests locally.
Update existing AWS workflow to be called instead of automatically triggering on PR.
Add entrypoint workflow for deciding whether AWS or local test workflow should run.
Rename workflows and simplify names.