Handle follow_up_requested as a distinct consent status#6339
Merged
Conversation
murugapl
force-pushed
the
follow-up-parent-journey
branch
from
d4d7cd5 to
58c0f92
Compare
murugapl
force-pushed
the
follow-up-nurse-facing
branch
3 times, most recently
from
0678b09 to
84b3e73
Compare
murugapl
force-pushed
the
follow-up-nurse-facing
branch
from
84b3e73 to
0773282
Compare
murugapl
force-pushed
the
follow-up-parent-journey
branch
2 times, most recently
from
6571fdd to
6a36bfe
Compare
murugapl
force-pushed
the
follow-up-nurse-facing
branch
from
0773282 to
160f00e
Compare
murugapl
force-pushed
the
follow-up-parent-journey
branch
from
6a36bfe to
ebe9dc9
Compare
murugapl
force-pushed
the
follow-up-nurse-facing
branch
from
160f00e to
ace75e0
Compare
thomasleese
approved these changes
Mar 19, 2026
murugapl
force-pushed
the
follow-up-nurse-facing
branch
from
ace75e0 to
ee1215f
Compare
murugapl
force-pushed
the
follow-up-nurse-facing
branch
from
ee1215f to
4acbae9
Compare
murugapl
force-pushed
the
follow-up-parent-journey
branch
2 times, most recently
from
ca066e8 to
9f3f8f7
Compare
murugapl
force-pushed
the
follow-up-nurse-facing
branch
2 times, most recently
from
a16fe2f to
5ade230
Compare
murugapl
force-pushed
the
follow-up-parent-journey
branch
from
9f3f8f7 to
63d4262
Compare
murugapl
force-pushed
the
follow-up-nurse-facing
branch
from
5ade230 to
50be206
Compare
murugapl
force-pushed
the
follow-up-parent-journey
branch
from
63d4262 to
bb8ae98
Compare
murugapl
force-pushed
the
follow-up-nurse-facing
branch
from
50be206 to
57758ec
Compare
murugapl
force-pushed
the
follow-up-parent-journey
branch
from
bb8ae98 to
ebe170e
Compare
murugapl
force-pushed
the
follow-up-nurse-facing
branch
from
57758ec to
30cf026
Compare
A consent recorded as `follow_up_requested` is semantically a refusal with the parent still open to discussion - not a definitive no. This means it needs its own consent status rather than being grouped with refused, and it affects conflict detection. Implements the previously stubbed `should_be_needs_consent_follow_up_requested?` In `StatusGenerator::Programme` so patients land in the "Needs consent / Follow-up requested" group rather than "Has a refusal". Updates conflict detection so that `follow_up_requested` is treated as the overall outcome when there are multiple consent responses only if that follow-up could change the overall outcome to `:given`. If there are other refusals, then we keep it as `:conflicts`
The raw enum value "follow_up_requested" was interpolated directly into the timeline title, producing "Consent follow_up_requested". Use Consent.human_enum_name to resolve the I18n translation instead, which yields the correct human-readable label for all response types ("Consent given", "Consent refused", "Follow-up requested").
murugapl
force-pushed
the
follow-up-nurse-facing
branch
from
30cf026 to
1c208eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the previously stubbed
should_be_needs_consent_follow_up_requested?InStatusGenerator::Programmeso patients land in the "Needs consent / Follow-up requested" group rather than "Has a refusal".Updates conflicting consent detection so that
follow_up_requestedis treated as the overall outcome when there are multiple consent responses only if that follow-up could change the overall outcome to:given. If there are other refusals, then we keep it as:conflicts.Jira Issue - MAV-526
Screenshots
...