Paginate already in mavis on import results#6292
Merged
Conversation
stevehook
force-pushed
the
paginate-import-results
branch
3 times, most recently
from
85303b7 to
8757469
Compare
stevehook
force-pushed
the
paginate-already-in-mavis-on-import-results
branch
2 times, most recently
from
f7447e5 to
f8f6b88
Compare
stevehook
commented
Mar 16, 2026
misaka
reviewed
Mar 19, 2026
stevehook
force-pushed
the
paginate-already-in-mavis-on-import-results
branch
from
8817f2b to
7f90700
Compare
stevehook
force-pushed
the
paginate-import-results
branch
from
8757469 to
be6b62c
Compare
Instead of manipulating query results as arrays to exclude patients that have moved school I'm using a `NOT IN (<list of ids>)` condition. I'm making an assumption here that the number of inter-school moves is not huge (and this is borne out by an examination of historical imports on prod). Jira-Issue: MAV-4109
stevehook
force-pushed
the
paginate-already-in-mavis-on-import-results
branch
from
7f90700 to
72ba042
Compare
This makes adds the anchor that we scroll to when the page is refreshed following a paging action. It also makes the detail component that contains that list open on page refresh so that the page stays in more or less the same state. Jira-Issue: MAV-4109
Jira-Issue: MAV-4109
Jira-Issue: MAV-4109
We have seen a 1+N query being flagged by `strict_loading` in `SchoolMove#from_another_team?` when displaying large datasets on the review import pages. Eager loading the `Patient#school_moves: :school_teams` associations fixes this and may help improve overall performance. Jira-Issue: MAV-4109
stevehook
force-pushed
the
paginate-already-in-mavis-on-import-results
branch
from
72ba042 to
d52ac28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #6257 and adds pagination to the Records already in Mavis, Import issues and School moves lists.
It also includes a fix for a potential 1+N query caused by lazy loading
SchoolMove#school_teams.Jira-Issue: https://nhsd-jira.digital.nhs.uk/browse/MAV-4109
Screenshots
Pre-release tasks
Post-release tasks