Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the “Gender identity” question page to align with an updated design, including new page copy and a dedicated template, while removing an outdated gender option.
Changes:
- Switch
GenderViewto render a newgender.jinjatemplate with updated heading and explanatory copy. - Remove the
GPgender option fromGenderValuesand update the field choices via a Django migration. - Add an “or” divider in the gender radio options after “Non-binary”.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lung_cancer_screening/questions/views/gender.py | Points the gender question view at the new dedicated template. |
| lung_cancer_screening/questions/models/gender_response.py | Removes the GP option from the gender enum choices. |
| lung_cancer_screening/questions/migrations/0008_alter_genderresponse_value.py | Alters the GenderResponse.value choices to match the updated enum. |
| lung_cancer_screening/questions/jinja2/gender.jinja | Adds updated page heading and explanatory copy for the gender page. |
| lung_cancer_screening/questions/forms/gender_form.py | Updates the form configuration and inserts a divider between radio options. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -9,7 +9,6 @@ class GenderValues(models.TextChoices): | |||
| MALE = "M", 'Male' | |||
Comment on lines
+12
to
+17
| operations = [ | ||
| migrations.AlterField( | ||
| model_name='genderresponse', | ||
| name='value', | ||
| field=models.CharField(choices=[('F', 'Female'), ('M', 'Male'), ('N', 'Non-binary'), ('P', 'Prefer not to say')], max_length=1), | ||
| ), |
Comment on lines
+21
to
+23
| # Add divider before "None of the above" | ||
| fields = self["value"] | ||
| fields.add_divider_after( |
|
|
||
| <p>The answers you submit will not be shared with your patient care advisor during your phone appointment, or with your GP.</p> | ||
|
|
||
| <p>In the future we plan to use information about someone's gender identity to help us plan their care in the NHS lung cancer screening programme.</p> |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change?
Updates to gender page
Why are we making this change?
Changes to gender page to meet updated design