Bug ved 1131 dlq for failed pds call fix#1315
Merged
avshetty1980 merged 5 commits intomasterfrom Mar 19, 2026
Merged
Conversation
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-1131 |
avshetty1980
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
avshetty1980
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
avshetty1980
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
avshetty1980
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
avshetty1980
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
avshetty1980
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
Thomas-Boyle
previously approved these changes
Mar 19, 2026
Thomas-Boyle
approved these changes
Mar 19, 2026
avshetty1980
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
avshetty1980
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
avshetty1980
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
avshetty1980
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
avshetty1980
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
avshetty1980
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
Akol125
approved these changes
Mar 19, 2026
|
Akol125
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Akol125
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Akol125
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Routine Change
updated queue visibility to 2160 to be 6 times the timeout of the id_sync lambda (360s)
added better logging and ensured correct return type so the DLQ can be triggered on faults
Add any other relevant notes or explanations here. Remove this line if you have nothing to add.
Reviews Required