VED-1103: Refactor Batch Processor (recordprocessor) deployment to a dedicated pipeline stage#1279
Open
Thomas-Boyle wants to merge 62 commits intomasterfrom
Open
VED-1103: Refactor Batch Processor (recordprocessor) deployment to a dedicated pipeline stage#1279Thomas-Boyle wants to merge 62 commits intomasterfrom
Thomas-Boyle wants to merge 62 commits intomasterfrom
Conversation
Contributor
Thomas-Boyle
commented
Mar 10, 2026
Thomas-Boyle
commented
- Added a new GitHub Actions workflow for deploying the Recordprocessor batch processor.
- Updated the continuous deployment workflow to include a dependency on the new Recordprocessor deployment.
- Introduced a new variable for the Recordprocessor image tag in Terraform configuration.
- Refactored ECS task definition to use the new image tag variable for the Recordprocessor container.
…deployment dependencies - Added a new GitHub Actions workflow for deploying the Recordprocessor batch processor. - Updated the continuous deployment workflow to include a dependency on the new Recordprocessor deployment. - Introduced a new variable for the Recordprocessor image tag in Terraform configuration. - Refactored ECS task definition to use the new image tag variable for the Recordprocessor container.
- Explicitly set the AWS_INFRA_ROLE_ARN secret in the continuous deployment workflow. - Upgrade aws-actions/configure-aws-credentials and aws-actions/amazon-ecr-login to specific versions for improved stability.
Thomas-Boyle
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Thomas-Boyle
had a problem deploying
to
internal-dev
GitHub Actions
Failure
Thomas-Boyle
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
- Removed the separate Recordprocessor deployment workflow and integrated its functionality into the backend deployment workflow. - Added a new input parameter `enable_recordprocessor` to conditionally build and push the Recordprocessor Docker image. - Updated dependencies in the backend deployment to ensure proper execution order and image tagging for the Recordprocessor. - Enhanced the continuous deployment workflow by simplifying dependencies and improving clarity.
edhall-nhs
previously requested changes
Mar 10, 2026
Contributor
edhall-nhs
left a comment
edhall-nhs
left a comment
There was a problem hiding this comment.
Discussed on a call but to summarise:
- Integrate in deploy-backend workflow, not separate
- Add manual check that ECR repo exists first
- Pass through new image tag
… repository - Changed the behavior of the ECR repository check to fail the build-and-push-recordprocessor job if the repository does not exist, instead of skipping the image build and push. This ensures that the deployment process is more robust and provides clearer feedback on repository availability.
Thomas-Boyle
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Thomas-Boyle
had a problem deploying
to
internal-dev
GitHub Actions
Failure
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
Thomas-Boyle
had a problem deploying
to
internal-dev
GitHub Actions
Failure
Thomas-Boyle
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
- Modified the backend deployment workflow to include a new step for resolving the image tag based on the `enable_recordprocessor` input. This change ensures that the image tag is set to the output of the build-and-push step if the Recordprocessor is enabled, otherwise defaults to "latest". This enhances the clarity and reliability of the image tagging process during deployment.
- Renamed the ECR repository from `processing_repository` to `recordprocessor_repository` for clarity. - Added a lifecycle policy to manage images, retaining the last 10 images to optimize storage and maintain relevant versions.
EmptyCommit:
…de the correct path for shared resources
Contributor
|
TODO: manually push account level changes to add lifecycle policy and update terraform name of ECR repository Warning |
…he correct path for shared resources
…clude shared resources
…nsure accurate path matching for recordprocessor changes
…cessing cessation.
…ng quality checks for PR deployments
This reverts commit 8cbf3ae.
…and streamline deployment conditions
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…dprocessor change detection
* Add cleanup step for recordprocessor ECR images in PR teardown workflow * Refactor PR teardown workflow to queue image deletions for recordprocessor ECR
… manual runs (#1301) * Enhance deploy-backend workflow to allow optional recordprocessor image tag input. Update logic to handle provided image tag during deployment, ensuring proper validation when building the image is disabled. * Clarify description for recordprocessor image tag in deploy-backend workflow, specifying its requirement when image building is disabled. * Remove conditional check for workflow dispatch in AWS connection step of deploy-backend workflow.
edhall-nhs
approved these changes
Mar 16, 2026
Contributor
edhall-nhs
left a comment
edhall-nhs
left a comment
There was a problem hiding this comment.
All looks good to me. I think we should hold off merging until there have been a few more reviews and we've done the team demo / workshop as it's a fundamental change
| "rules": [ | ||
| { | ||
| "rulePriority": 1, | ||
| "description": "Keep last 10 images", |
Contributor
There was a problem hiding this comment.
We can discuss this policy in the demo to see what the team thinks. Might be that we can get rid of it tbh since we've updated the PR teardown now.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.