Skip to content

Chore: [AEA-0000] - workflow to update dev container#1950

Open
anthony-nhs wants to merge 2 commits intomainfrom
update_dev_container
Open

Chore: [AEA-0000] - workflow to update dev container#1950
anthony-nhs wants to merge 2 commits intomainfrom
update_dev_container

Conversation

@anthony-nhs
Copy link
Contributor

Summary

  • Routine Change

Details

  • workflow to update dev container

Copilot AI review requested due to automatic review settings March 25, 2026 09:54
@github-actions
Copy link
Contributor

This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket:

AEA-0000

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a GitHub Actions workflow to automate updating the repository’s devcontainer version by invoking the shared eps-common-workflows reusable workflow.

Changes:

  • Introduces a new scheduled + manual (workflow_dispatch) workflow to update the devcontainer version.
  • Configures job permissions and passes automerge GitHub App secrets into the reusable workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +12 to +14
contents: read
packages: read
pull-requests: write
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

permissions: values are indented more deeply than elsewhere in this repo’s workflow files (e.g., other workflows use two-space indentation under permissions:). While YAML will still parse, matching the existing indentation improves readability and reduces the chance of future YAML indentation mistakes.

Suggested change
contents: read
packages: read
pull-requests: write
contents: read
packages: read
pull-requests: write

Copilot uses AI. Check for mistakes.

jobs:
update_devcontainer_version:
uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@d2a4595b1bfa59f04c7cecb080a126321d42a333
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow pins NHSDigital/eps-common-workflows to a different commit SHA than the rest of the repo’s workflows (which consistently use @5ac2707…). If possible, align this uses: ref to the same SHA as the other workflows, or update the other workflows to the new SHA in the same PR to avoid maintaining multiple versions of the shared workflow set.

Suggested change
uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@d2a4595b1bfa59f04c7cecb080a126321d42a333
uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@5ac2707b1bfa59f04c7cecb080a126321d42a333

Copilot uses AI. Check for mistakes.
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants