Fix: [AEA-6055] - debugging issues with post-dated updates#2814
Open
tstephen-nhs wants to merge 62 commits intomainfrom
Open
Fix: [AEA-6055] - debugging issues with post-dated updates#2814tstephen-nhs wants to merge 62 commits intomainfrom
tstephen-nhs wants to merge 62 commits intomainfrom
Conversation
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-6055 |
42ac0af to
4d3c4fe
Compare
b67e7e5 to
e48be95
Compare
…workflows/pr_title_check.yml from 5.6.4 to 5.6.6 (#2866) Bumps [NHSDigital/eps-common-workflows/.github/workflows/pr_title_check.yml](https://github.com/nhsdigital/eps-common-workflows) from 5.6.4 to 5.6.6. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/nhsdigital/eps-common-workflows/releases">NHSDigital/eps-common-workflows/.github/workflows/pr_title_check.yml's releases</a>.</em></p> <blockquote> <h2>v5.6.6</h2> <h2><a href="https://github.com/NHSDigital/eps-common-workflows/compare/v5.6.5...v5.6.6">5.6.6</a> (2026-03-12)</h2> <h3>Upgrade</h3> <ul> <li>[dependabot] - bump tar and npm (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/86">#86</a>) (<a href="https://github.com/NHSDigital/eps-common-workflows/commit/383f3f9eaf3cb553ebcd74897bfed4d5e387629e">383f3f9</a>)</li> </ul> <h2>Info</h2> <p><a href="https://github.com/NHSDigital/eps-common-workflows/actions/runs/23004076858">Release workflow run</a> - Workflow ID: 23004076858</p> <p>It was initialized by <a href="https://github.com/apps/eps-autoapprove-dependabot">eps-autoapprove-dependabot[bot]</a></p> <h2>v5.6.5</h2> <h2><a href="https://github.com/NHSDigital/eps-common-workflows/compare/v5.6.4...v5.6.5">5.6.5</a> (2026-03-12)</h2> <h3>Chore</h3> <ul> <li>[AEA-0000] - stagger dependabot (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/88">#88</a>) (<a href="https://github.com/NHSDigital/eps-common-workflows/commit/ee437c09a9cdae970785be341a66bb4a817c9eb4">ee437c0</a>)</li> </ul> <h3>Upgrade</h3> <ul> <li>[dependabot] - bump actions/download-artifact from 8.0.0 to 8.0.1 (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/89">#89</a>) (<a href="https://github.com/NHSDigital/eps-common-workflows/commit/a9006399b56ed2a9bf066bfa2eb84a26b7e3630f">a900639</a>)</li> <li>[dependabot] - bump aquasecurity/trivy-action from 0.34.2 to 0.35.0 (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/91">#91</a>) (<a href="https://github.com/NHSDigital/eps-common-workflows/commit/0c823d889ee6521f4524ccf097503007154047b1">0c823d8</a>)</li> <li>[dependabot] - bump semantic-release-pypi from 5.1.3 to 5.2.0 (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/90">#90</a>) (<a href="https://github.com/NHSDigital/eps-common-workflows/commit/14bf1b5a428a41ca7a18bb7766794352cdee9b64">14bf1b5</a>)</li> </ul> <h2>Info</h2> <p><a href="https://github.com/NHSDigital/eps-common-workflows/actions/runs/23002139669">Release workflow run</a> - Workflow ID: 23002139669</p> <p>It was initialized by <a href="https://github.com/apps/eps-autoapprove-dependabot">eps-autoapprove-dependabot[bot]</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/NHSDigital/eps-common-workflows/commit/383f3f9eaf3cb553ebcd74897bfed4d5e387629e"><code>383f3f9</code></a> Upgrade: [dependabot] - bump tar and npm (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/86">#86</a>)</li> <li><a href="https://github.com/NHSDigital/eps-common-workflows/commit/a9006399b56ed2a9bf066bfa2eb84a26b7e3630f"><code>a900639</code></a> Upgrade: [dependabot] - bump actions/download-artifact from 8.0.0 to 8.0.1 (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/89">#89</a>)</li> <li><a href="https://github.com/NHSDigital/eps-common-workflows/commit/0c823d889ee6521f4524ccf097503007154047b1"><code>0c823d8</code></a> Upgrade: [dependabot] - bump aquasecurity/trivy-action from 0.34.2 to 0.35.0 ...</li> <li><a href="https://github.com/NHSDigital/eps-common-workflows/commit/14bf1b5a428a41ca7a18bb7766794352cdee9b64"><code>14bf1b5</code></a> Upgrade: [dependabot] - bump semantic-release-pypi from 5.1.3 to 5.2.0 (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/90">#90</a>)</li> <li><a href="https://github.com/NHSDigital/eps-common-workflows/commit/ee437c09a9cdae970785be341a66bb4a817c9eb4"><code>ee437c0</code></a> Chore: [AEA-0000] - stagger dependabot (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/88">#88</a>)</li> <li>See full diff in <a href="https://github.com/nhsdigital/eps-common-workflows/compare/dac60c1e29babc62013e7bb9ade002cb381c4c49...383f3f9eaf3cb553ebcd74897bfed4d5e387629e">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…workflows/get-repo-config.yml from 5.6.4 to 5.6.6 (#2865) Bumps [NHSDigital/eps-common-workflows/.github/workflows/get-repo-config.yml](https://github.com/nhsdigital/eps-common-workflows) from 5.6.4 to 5.6.6. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/nhsdigital/eps-common-workflows/releases">NHSDigital/eps-common-workflows/.github/workflows/get-repo-config.yml's releases</a>.</em></p> <blockquote> <h2>v5.6.6</h2> <h2><a href="https://github.com/NHSDigital/eps-common-workflows/compare/v5.6.5...v5.6.6">5.6.6</a> (2026-03-12)</h2> <h3>Upgrade</h3> <ul> <li>[dependabot] - bump tar and npm (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/86">#86</a>) (<a href="https://github.com/NHSDigital/eps-common-workflows/commit/383f3f9eaf3cb553ebcd74897bfed4d5e387629e">383f3f9</a>)</li> </ul> <h2>Info</h2> <p><a href="https://github.com/NHSDigital/eps-common-workflows/actions/runs/23004076858">Release workflow run</a> - Workflow ID: 23004076858</p> <p>It was initialized by <a href="https://github.com/apps/eps-autoapprove-dependabot">eps-autoapprove-dependabot[bot]</a></p> <h2>v5.6.5</h2> <h2><a href="https://github.com/NHSDigital/eps-common-workflows/compare/v5.6.4...v5.6.5">5.6.5</a> (2026-03-12)</h2> <h3>Chore</h3> <ul> <li>[AEA-0000] - stagger dependabot (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/88">#88</a>) (<a href="https://github.com/NHSDigital/eps-common-workflows/commit/ee437c09a9cdae970785be341a66bb4a817c9eb4">ee437c0</a>)</li> </ul> <h3>Upgrade</h3> <ul> <li>[dependabot] - bump actions/download-artifact from 8.0.0 to 8.0.1 (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/89">#89</a>) (<a href="https://github.com/NHSDigital/eps-common-workflows/commit/a9006399b56ed2a9bf066bfa2eb84a26b7e3630f">a900639</a>)</li> <li>[dependabot] - bump aquasecurity/trivy-action from 0.34.2 to 0.35.0 (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/91">#91</a>) (<a href="https://github.com/NHSDigital/eps-common-workflows/commit/0c823d889ee6521f4524ccf097503007154047b1">0c823d8</a>)</li> <li>[dependabot] - bump semantic-release-pypi from 5.1.3 to 5.2.0 (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/90">#90</a>) (<a href="https://github.com/NHSDigital/eps-common-workflows/commit/14bf1b5a428a41ca7a18bb7766794352cdee9b64">14bf1b5</a>)</li> </ul> <h2>Info</h2> <p><a href="https://github.com/NHSDigital/eps-common-workflows/actions/runs/23002139669">Release workflow run</a> - Workflow ID: 23002139669</p> <p>It was initialized by <a href="https://github.com/apps/eps-autoapprove-dependabot">eps-autoapprove-dependabot[bot]</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/NHSDigital/eps-common-workflows/commit/383f3f9eaf3cb553ebcd74897bfed4d5e387629e"><code>383f3f9</code></a> Upgrade: [dependabot] - bump tar and npm (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/86">#86</a>)</li> <li><a href="https://github.com/NHSDigital/eps-common-workflows/commit/a9006399b56ed2a9bf066bfa2eb84a26b7e3630f"><code>a900639</code></a> Upgrade: [dependabot] - bump actions/download-artifact from 8.0.0 to 8.0.1 (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/89">#89</a>)</li> <li><a href="https://github.com/NHSDigital/eps-common-workflows/commit/0c823d889ee6521f4524ccf097503007154047b1"><code>0c823d8</code></a> Upgrade: [dependabot] - bump aquasecurity/trivy-action from 0.34.2 to 0.35.0 ...</li> <li><a href="https://github.com/NHSDigital/eps-common-workflows/commit/14bf1b5a428a41ca7a18bb7766794352cdee9b64"><code>14bf1b5</code></a> Upgrade: [dependabot] - bump semantic-release-pypi from 5.1.3 to 5.2.0 (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/90">#90</a>)</li> <li><a href="https://github.com/NHSDigital/eps-common-workflows/commit/ee437c09a9cdae970785be341a66bb4a817c9eb4"><code>ee437c0</code></a> Chore: [AEA-0000] - stagger dependabot (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/88">#88</a>)</li> <li>See full diff in <a href="https://github.com/nhsdigital/eps-common-workflows/compare/dac60c1e29babc62013e7bb9ade002cb381c4c49...383f3f9eaf3cb553ebcd74897bfed4d5e387629e">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…workflows/dependabot-auto-approve-and-merge.yml from 5.6.4 to 5.6.6 (#2864) Bumps [NHSDigital/eps-common-workflows/.github/workflows/dependabot-auto-approve-and-merge.yml](https://github.com/nhsdigital/eps-common-workflows) from 5.6.4 to 5.6.6. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/nhsdigital/eps-common-workflows/releases">NHSDigital/eps-common-workflows/.github/workflows/dependabot-auto-approve-and-merge.yml's releases</a>.</em></p> <blockquote> <h2>v5.6.6</h2> <h2><a href="https://github.com/NHSDigital/eps-common-workflows/compare/v5.6.5...v5.6.6">5.6.6</a> (2026-03-12)</h2> <h3>Upgrade</h3> <ul> <li>[dependabot] - bump tar and npm (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/86">#86</a>) (<a href="https://github.com/NHSDigital/eps-common-workflows/commit/383f3f9eaf3cb553ebcd74897bfed4d5e387629e">383f3f9</a>)</li> </ul> <h2>Info</h2> <p><a href="https://github.com/NHSDigital/eps-common-workflows/actions/runs/23004076858">Release workflow run</a> - Workflow ID: 23004076858</p> <p>It was initialized by <a href="https://github.com/apps/eps-autoapprove-dependabot">eps-autoapprove-dependabot[bot]</a></p> <h2>v5.6.5</h2> <h2><a href="https://github.com/NHSDigital/eps-common-workflows/compare/v5.6.4...v5.6.5">5.6.5</a> (2026-03-12)</h2> <h3>Chore</h3> <ul> <li>[AEA-0000] - stagger dependabot (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/88">#88</a>) (<a href="https://github.com/NHSDigital/eps-common-workflows/commit/ee437c09a9cdae970785be341a66bb4a817c9eb4">ee437c0</a>)</li> </ul> <h3>Upgrade</h3> <ul> <li>[dependabot] - bump actions/download-artifact from 8.0.0 to 8.0.1 (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/89">#89</a>) (<a href="https://github.com/NHSDigital/eps-common-workflows/commit/a9006399b56ed2a9bf066bfa2eb84a26b7e3630f">a900639</a>)</li> <li>[dependabot] - bump aquasecurity/trivy-action from 0.34.2 to 0.35.0 (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/91">#91</a>) (<a href="https://github.com/NHSDigital/eps-common-workflows/commit/0c823d889ee6521f4524ccf097503007154047b1">0c823d8</a>)</li> <li>[dependabot] - bump semantic-release-pypi from 5.1.3 to 5.2.0 (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/90">#90</a>) (<a href="https://github.com/NHSDigital/eps-common-workflows/commit/14bf1b5a428a41ca7a18bb7766794352cdee9b64">14bf1b5</a>)</li> </ul> <h2>Info</h2> <p><a href="https://github.com/NHSDigital/eps-common-workflows/actions/runs/23002139669">Release workflow run</a> - Workflow ID: 23002139669</p> <p>It was initialized by <a href="https://github.com/apps/eps-autoapprove-dependabot">eps-autoapprove-dependabot[bot]</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/NHSDigital/eps-common-workflows/commit/383f3f9eaf3cb553ebcd74897bfed4d5e387629e"><code>383f3f9</code></a> Upgrade: [dependabot] - bump tar and npm (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/86">#86</a>)</li> <li><a href="https://github.com/NHSDigital/eps-common-workflows/commit/a9006399b56ed2a9bf066bfa2eb84a26b7e3630f"><code>a900639</code></a> Upgrade: [dependabot] - bump actions/download-artifact from 8.0.0 to 8.0.1 (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/89">#89</a>)</li> <li><a href="https://github.com/NHSDigital/eps-common-workflows/commit/0c823d889ee6521f4524ccf097503007154047b1"><code>0c823d8</code></a> Upgrade: [dependabot] - bump aquasecurity/trivy-action from 0.34.2 to 0.35.0 ...</li> <li><a href="https://github.com/NHSDigital/eps-common-workflows/commit/14bf1b5a428a41ca7a18bb7766794352cdee9b64"><code>14bf1b5</code></a> Upgrade: [dependabot] - bump semantic-release-pypi from 5.1.3 to 5.2.0 (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/90">#90</a>)</li> <li><a href="https://github.com/NHSDigital/eps-common-workflows/commit/ee437c09a9cdae970785be341a66bb4a817c9eb4"><code>ee437c0</code></a> Chore: [AEA-0000] - stagger dependabot (<a href="https://redirect.github.com/nhsdigital/eps-common-workflows/issues/88">#88</a>)</li> <li>See full diff in <a href="https://github.com/nhsdigital/eps-common-workflows/compare/dac60c1e29babc62013e7bb9ade002cb381c4c49...383f3f9eaf3cb553ebcd74897bfed4d5e387629e">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds instrumentation and deployment toggles to help investigate and control behavior around post-dated prescription status updates, including optionally exposing a new API endpoint.
Changes:
- Add additional logging around post-dated updates and GSUL update filtering/grouping.
- Introduce
ExposeGetStatusUpdates/EXPOSE_GET_STATUS_UPDATESto conditionally deploy and publish theget-status-updatesAPI Gateway endpoint and API spec. - Extend DynamoDB GSI projection to include
PostDatedLastModifiedSetAt, and update CI/release workflows + Trivy ignore list.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/updatePrescriptionStatus/src/updatePrescriptionStatus.ts | Logs post-dated update detection during data item construction. |
| packages/gsul/src/getStatusUpdates.ts | Adds debug/info logs around filtering and reducing status updates. |
| SAMtemplates/tables/main.yaml | Adds PostDatedLastModifiedSetAt to a GSI projection. |
| SAMtemplates/main_template.yaml | Adds ExposeGetStatusUpdates parameter and wires it into nested stacks. |
| SAMtemplates/apis/main.yaml | Conditionally adds /get-status-updates API Gateway resource/method and deployment dependency. |
| .trivyignore.yaml | Adds a new CVE risk acceptance entry. |
| .github/workflows/run_release_code_and_api.yml | Adds EXPOSE_GET_STATUS_UPDATES workflow input and passes it through. |
| .github/workflows/run_regression_tests.yml | Bumps regression test repo/workflow tag versions. |
| .github/workflows/release.yml | Sets EXPOSE_GET_STATUS_UPDATES per environment/job. |
| .github/workflows/pull_request.yml | Sets EXPOSE_GET_STATUS_UPDATES for PR deployments. |
| .github/workflows/ci.yml | Sets EXPOSE_GET_STATUS_UPDATES for CI deployments. |
| .github/scripts/release_code.sh | Passes ExposeGetStatusUpdates into sam deploy parameter overrides. |
| .github/scripts/deploy_api.sh | Removes /get-status-updates from the published spec when not exposed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
69fa054 to
e93a804
Compare
7e60ff2 to
52974d7
Compare
f3cf68e to
6a4e064
Compare
tstephen-nhs
commented
Mar 18, 2026
| if [[ "$TARGET_ENVIRONMENT" != "prod" && "$TARGET_ENVIRONMENT" != "ref" ]]; then | ||
| # this should be the tag of the tests you want to run | ||
| REGRESSION_TEST_REPO_TAG=v3.6.2 | ||
| REGRESSION_TEST_REPO_TAG=v3.11.0 |
Contributor
Author
There was a problem hiding this comment.
Set in anticipation, not yet published, hence check failure.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Details