[ELI-619] - cache campaign configs unless we send a bypass header and not in local#610
[ELI-619] - cache campaign configs unless we send a bypass header and not in local#610
Conversation
|
This is just a poc, will wait to add test coverage to see if people like it |
|
I check the updated PR, looks good. Nice solution. (previous solution used headers for cache enable/disable) I think, we might was a bit of thought around how we control the test consumer ids. When you originally mentioned this idea, before I looked at the PR, Maybe just needs a bit of thought around this hard coded test consumer ids, see if that is what we want. If yes, then all look great to me, nice solution. |
Description
I've implemented an idea that looks like it would be a nice easy fit to grab some performance back.
Added some unit tests to show the cache being used and then expiring
Difficult to fully integration test without deploying but I've showed that it works at least (with a little fudging). This involves setting the env variable to "dev" in the docker set up for local runs, just for that commented out int test.
Context
stops fetching from s3 every single request
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.