-
Notifications
You must be signed in to change notification settings - Fork 7
Update: [AEA-4652] - signature validation on prescription creation #4426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bencegadanyi1-nhs
merged 43 commits into
master
from
AEA-4652-add-prescription-order-endpoint-signature-validation
Apr 2, 2026
Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
8e135d2
feat: implement toggled signature validation
bencegadanyi1-nhs 9e5ac52
Merge branch 'master' into AEA-4652-add-prescription-order-endpoint-s…
bencegadanyi1-nhs d7b3689
feat: implement toggled signature validation
bencegadanyi1-nhs 935dca7
feat: implements and tests signature validation
bencegadanyi1-nhs 83b2c11
Merge branch 'master' into AEA-4652-add-prescription-order-endpoint-s…
bencegadanyi1-nhs f82a5d9
chore: stack export signature validation feature flag value
bencegadanyi1-nhs 5508536
chore: set regression test pack
bencegadanyi1-nhs f024acc
test: update pact tests
bencegadanyi1-nhs e2546cf
chore: trivy ignore fast-xml-parser
bencegadanyi1-nhs 65c9f1b
chore: removes redundant try catch
bencegadanyi1-nhs 4ed880e
chore: changes test description
bencegadanyi1-nhs 1347b85
test: adds missing diagnostic field
bencegadanyi1-nhs 3f5592f
chore: reverts testcases
bencegadanyi1-nhs d6ca7b2
feat: sign prescriptions with invalid checksum for Spine response
bencegadanyi1-nhs da1f9a0
feat: sign prescriptions with invalid checksum for Spine response
bencegadanyi1-nhs 0cfbed1
chore: passing pull-request-id to regression tests
bencegadanyi1-nhs 590fe99
test: process route coverage
bencegadanyi1-nhs 204e4a4
chore: remove pull request id for regression tests
bencegadanyi1-nhs d886f76
chore: word change
bencegadanyi1-nhs f08a8c6
tirgger build
bencegadanyi1-nhs 34e0b62
Merge branch 'master' into AEA-4652-add-prescription-order-endpoint-s…
bencegadanyi1-nhs c74d7e9
refactor: avoids double translation by reusing ParentPrescription
bencegadanyi1-nhs ea7d52a
Merge branch 'master' into AEA-4652-add-prescription-order-endpoint-s…
bencegadanyi1-nhs 22051b5
chore: addresses SQ code smells
bencegadanyi1-nhs cb8a615
chore: enable signature validation in apim
bencegadanyi1-nhs ca8ca7a
trigger build
bencegadanyi1-nhs 9e441d0
Merge branch 'master' into AEA-4652-add-prescription-order-endpoint-s…
bencegadanyi1-nhs 6efeaa1
Merge branch 'master' into AEA-4652-add-prescription-order-endpoint-s…
bencegadanyi1-nhs 658ed82
chore: address regression test and TODO comments
bencegadanyi1-nhs fa1f88c
Merge branch 'master' into AEA-4652-add-prescription-order-endpoint-s…
bencegadanyi1-nhs 6dabc25
test: adds pct test backward compatibility
bencegadanyi1-nhs f0d93ac
chore: add signature validation flag to each env on APIM
bencegadanyi1-nhs c78565c
Merge branch 'master' into AEA-4652-add-prescription-order-endpoint-s…
bencegadanyi1-nhs c706937
trigger build
bencegadanyi1-nhs 3f8fecc
Merge branch 'master' into AEA-4652-add-prescription-order-endpoint-s…
bencegadanyi1-nhs cea52f3
Merge branch 'master' into AEA-4652-add-prescription-order-endpoint-s…
bencegadanyi1-nhs 4c9f818
feat: makes the feature flag conditioned on apim
bencegadanyi1-nhs 8ccc53f
Merge branch 'master' into AEA-4652-add-prescription-order-endpoint-s…
bencegadanyi1-nhs 33cc962
Merge branch 'master' into AEA-4652-add-prescription-order-endpoint-s…
bencegadanyi1-nhs 417f56e
trigger build
bencegadanyi1-nhs a0781ef
chore: addresses commments making validation DRY and removes pointles…
bencegadanyi1-nhs 9c29864
Merge branch 'master' into AEA-4652-add-prescription-order-endpoint-s…
bencegadanyi1-nhs b610beb
chore: removes 2nd import
bencegadanyi1-nhs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| import { | ||
| App, | ||
| CfnOutput, | ||
| Duration, | ||
| Environment, | ||
| Fn, | ||
|
|
@@ -39,11 +40,11 @@ import { | |
| import {LogGroup} from "aws-cdk-lib/aws-logs" | ||
|
|
||
| export interface PrescribeDispenseStackProps extends StackProps { | ||
| readonly env: Environment | ||
| readonly serviceName: string | ||
| readonly stackName: string | ||
| readonly version: string | ||
| } | ||
| readonly env: Environment | ||
| readonly serviceName: string | ||
| readonly stackName: string | ||
| readonly version: string | ||
| } | ||
|
|
||
| export class PrescribeDispenseStack extends Stack { | ||
|
|
||
|
|
@@ -71,6 +72,8 @@ export class PrescribeDispenseStack extends Stack { | |
| const trustStoreVersion: string = this.node.tryGetContext("trustStoreVersion") | ||
| const SHA1EnabledApplicationIds: string = this.node.tryGetContext("SHA1EnabledApplicationIds") | ||
| const sandboxModeEnabled: string = this.node.tryGetContext("sandboxModeEnabled") | ||
| const enablePrescribingSignatureValidation: boolean = this.node | ||
| .tryGetContext("enablePrescribingSignatureValidation") | ||
| const desiredFhirFacadeCount: number = this.node.tryGetContext("desiredFhirFacadeCount") | ||
| const desiredClaimsCount: number = this.node.tryGetContext("desiredClaimsCount") | ||
| const desiredPeakClaimsCount: number = this.node.tryGetContext("desiredPeakClaimsCount") | ||
|
|
@@ -164,6 +167,7 @@ export class PrescribeDispenseStack extends Stack { | |
| coordinatorLogGroup: logGroups.coordinatorLogGroup, | ||
| validatorLogGroup: logGroups.validatorLogGroup, | ||
| SHA1EnabledApplicationIds: SHA1EnabledApplicationIds, | ||
| enablePrescribingSignatureValidation: enablePrescribingSignatureValidation, | ||
| sandboxModeEnabled: sandboxModeEnabled, | ||
| cpu: serviceCpu, | ||
| memory: serviceMemory, | ||
|
|
@@ -197,6 +201,7 @@ export class PrescribeDispenseStack extends Stack { | |
| coordinatorLogGroup: logGroups.claimsCoordinatorLogGroup, | ||
| validatorLogGroup: logGroups.claimsValidatorLogGroup, | ||
| SHA1EnabledApplicationIds: SHA1EnabledApplicationIds, | ||
| enablePrescribingSignatureValidation: enablePrescribingSignatureValidation, | ||
| sandboxModeEnabled: sandboxModeEnabled, | ||
| cpu: serviceCpu, | ||
| memory: serviceMemory, | ||
|
|
@@ -394,6 +399,12 @@ export class PrescribeDispenseStack extends Stack { | |
| Port.tcp(containerPort), | ||
| "Allow traffic to Claims Service from FHIR Facade load balancer" | ||
| ) | ||
|
|
||
| new CfnOutput(this, "EnablePrescribingSignatureValidation", { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm wondering why this is output when others aren't? I can't see it being used, sorry if I've missed it. |
||
| value: String(enablePrescribingSignatureValidation), | ||
| exportName: `${props.stackName}:enablePrescribingSignatureValidation` | ||
| }) | ||
|
|
||
| nagSuppressions(this) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.