fix: force rebuild base images bug fix#1862
Merged
MWClayson-NHS merged 3 commits intomainfrom Mar 20, 2026
Merged
Conversation
MWClayson-NHS
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the deployment script logic for detecting base-image-affecting changes so CI can correctly decide when to rebuild base images, especially when changes occur under nested directories.
Changes:
- Normalize
./prefixes and improve matching logic so base paths can match nested changed paths (directory-prefix matching). - Add a temporary XML doc comment line in a shared C# model (appears unrelated to the script fix).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/deployment/check-base-image-changes.sh | Improves path normalization and matching to correctly detect base image change triggers. |
| application/CohortManager/src/Functions/Shared/Model/BasicParticipantCsvRecord.cs | Adds a documentation comment line that appears to be a temporary “force rebuild” marker. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
application/CohortManager/src/Functions/Shared/Model/BasicParticipantCsvRecord.cs
Outdated
Show resolved
Hide resolved
|
rfk-nc
approved these changes
Mar 19, 2026
rfk-nc
added
the
Non-functional change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.