Skip to content

feat: DTOSS-12284 send servicenow notification on error#1861

Open
hardik-desai-nhs wants to merge 6 commits intomainfrom
DTOSS-12284_Fix_Error_Message_not_sending_to_Service_now
Open

feat: DTOSS-12284 send servicenow notification on error#1861
hardik-desai-nhs wants to merge 6 commits intomainfrom
DTOSS-12284_Fix_Error_Message_not_sending_to_Service_now

Conversation

@hardik-desai-nhs
Copy link

Description

send service now update when error processing manual add participant

Context

When a participant is manually added to the cohort, and hits a validation rule which prevents them from sending to BS Select. The Service now message going back to inform the user that the participant they have raised a manual add request for will not be sent to BS select because of some processing issue.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@github-actions
Copy link

Your Pull Request title must meet the conventional commit standards, please see the following documentation - https://www.conventionalcommits.org/en/v1.0.0/#specification

@hardik-desai-nhs hardik-desai-nhs changed the title send ServiceNowFailureNotification on error DTOSS-12284 send ServiceNow Notification on error Mar 17, 2026
@hardik-desai-nhs hardik-desai-nhs changed the title DTOSS-12284 send ServiceNow Notification on error DTOSS-12284 send servicenow notification on error Mar 17, 2026
@github-actions
Copy link

Your Pull Request title must meet the conventional commit standards, please see the following documentation - https://www.conventionalcommits.org/en/v1.0.0/#specification

@hardik-desai-nhs hardik-desai-nhs changed the title DTOSS-12284 send servicenow notification on error feat DTOSS-12284 send servicenow notification on error Mar 17, 2026
@hardik-desai-nhs hardik-desai-nhs changed the title feat DTOSS-12284 send servicenow notification on error feat: DTOSS-12284 send servicenow notification on error Mar 17, 2026
@github-actions
Copy link

github-actions bot commented Mar 17, 2026

Unit Test Results

✔️ Tests 1017 / 1017 - passed in 71s
📝 Coverage 47.11%
📏 4797 / 10482 lines covered 🌿 1175 / 2194 branches covered
🔍 click here for more details

✏️ updated for commit a1fee10

@sonarqubecloud
Copy link

Copy link
Contributor

@MWClayson-NHS MWClayson-NHS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good so far, You are missing one component of this where if there is an exception in the ValidateParticipant Specifically - HandleValidationExceptions method i.e. the participant has failed the rules. This will also need to trigger a response to ServceNow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants