Merged
Conversation
nhsd-jack-wainwright
force-pushed
the
feature/CDAPI-85
branch
from
0551f52 to
41acb90
Compare
|
✅ Trivy gate: no Critical/High vulnerabilities. Trivy Filesystem Scan SummaryFilesystem: /tmp/artifact
✅ No vulnerabilities found. |
nhsd-rebecca-flynn
approved these changes
Mar 19, 2026
Contributor
nhsd-rebecca-flynn
left a comment
nhsd-rebecca-flynn
left a comment
There was a problem hiding this comment.
LGTM. A couple of minor queries/ suggestions
nhsd-jack-wainwright
force-pushed
the
feature/CDAPI-78-w-infra
branch
2 times, most recently
from
dc3caf2 to
ccaf7d2
Compare
nhsd-jack-wainwright
force-pushed
the
feature/CDAPI-85
branch
from
730f22c to
4093d6a
Compare
nhsd-rebecca-flynn
approved these changes
Mar 19, 2026
Initial Introduction of the ApimAuthenticator class, handling authentication with the API Management platform utilising Signed JWT application restricted access. This commit also includes the creation of a `SessionManager` class handling the creation of a `request.Session` object with appropriate default configuration.
nhsd-jack-wainwright
force-pushed
the
feature/CDAPI-85
branch
from
4093d6a to
8a8d338
Compare
|
|
Deployment Complete
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implementation of an APIM client implementing the Application-restricted RESTful APIs - signed JWT authentication authentication paradigm.
Context
This change implements an APIM client that can be relied upon as part of subsequent work to integrate with both PDM and MNS.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.