[GPCAPIM-289] - Add dependacies to dev container image#117
[GPCAPIM-289] - Add dependacies to dev container image#117
Conversation
- Define STUB_SDS, STUB_PDS, and STUB_PROVIDER in the workflow environment
|
✅ Trivy gate: no Critical/High issues. Trivy IaC (Terraform) Summary
Findings (top 50)
|
|
✅ Trivy gate: no Critical/High vulnerabilities. Trivy Image Scan SummaryImage: 900119715266.dkr.ecr.eu-west-2.amazonaws.com/whoami:bugfix-gpcapim-289
✅ No vulnerabilities found. |
|
✅ Trivy gate: no Critical/High vulnerabilities. Trivy Image Scan SummaryImage: 900119715266.dkr.ecr.eu-west-2.amazonaws.com/whoami:bugfix-gpcapim-289
✅ No vulnerabilities found. |
There was a problem hiding this comment.
Pull request overview
This PR updates the build/dev container image to include additional development libraries needed for building dependencies inside the container.
Changes:
- Add
libxml2-devandlibxslt-devto the Alpineapk addpackage list. - Adjust the package list around
zstd-devto include the new dependencies.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Adds missing native development libraries to the build/dev container image so Python packages that depend on libxml2/libxslt can compile successfully in the devcontainer/CI build environment.
Changes:
- Install
libxml2-devandlibxslt-devin the build-container image.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Copy dev certificates into the gateway-api image build context if present - Update .gitignore to include dev-certificates directory
There was a problem hiding this comment.
Pull request overview
Adds development-time dependencies and optional dev CA certificate propagation into the gateway-api image build context to better align trust stores between the dev container and the built image.
Changes:
- Ignore
resources/dev-certificatesin the gateway-api image build context. - Optionally copy dev certificates into the gateway-api Docker build context and install them in the gateway-api image when present.
- Add
libxml2-devandlibxslt-devto the build-container image to support builds needing those native libs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| infrastructure/images/gateway-api/resources/.gitignore | Ignores dev certificate build-context directory. |
| infrastructure/images/gateway-api/Dockerfile | Installs dev CA certificates from the build context when provided. |
| infrastructure/images/build-container/Dockerfile | Adds XML/XSLT development libraries to the build container. |
| Makefile | Copies dev certificates into the gateway-api image build context when present. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| cp -r /resources/dev-certificates/* /usr/local/share/ca-certificates/; \ | ||
| update-ca-certificates; \ | ||
| cp -r /resources/dev-certificates/* /etc/ssl/certs/; \ |
| cp -r /resources/dev-certificates/* /usr/local/share/ca-certificates/; \ | ||
| update-ca-certificates; \ | ||
| cp -r /resources/dev-certificates/* /etc/ssl/certs/; \ |
| @if [ -d "/resources/dev-certificates" ]; then \ | ||
| rm -rf ../infrastructure/images/gateway-api/resources/dev-certificates; \ |
|
|
Deployment Complete
|
Include necessary development libraries in the dev contatiner.