Adding ServiceType parameter to role assignments#49
Merged
johncollinson2001 merged 1 commit intomainfrom Jun 6, 2025
Merged
Conversation
johncollinson2001
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Azure Landing Zone User Access Admin role has specific ABAC conditions - one of those conditions is that any role requests must have the origin source as 'ServicePrincipal'.
Terraform does not set this tag - and this is fine for scenarios without ABAC. Due to the condition requiring the parameter, it must be set.
I have added a simple line to reflect this - it poses no dangers or downsides.
If this change was not made, we would not be able to consume this module within the Landing Zone.
Type of change
Please check the relevant options:
🔲 New feature (a change which adds functionality)
✅ Bug fix (a change which fixes an issue)
🔲 Refactoring (code cleanup or optimisation)
🔲 Testing (new tests, or improvements to existing tests)
🔲 Pipelines (changes to pipelines and workflows)
🔲 Documentation (changes to documentation)
🔲 Other (something that's not listed here - please explain)
Checklist
Please check the relevant options:
✅ My code aligns with the style of this project
🔲 I have added comments in hard to understand areas NA
🔲 I have added tests that prove my change works NA
🔲 I have updated the documentation NA
✅ If merging into main, I'm aware that the PR should be squash merged with a commit message that adheres to the semantic release format
Additional Information
Please provide any additional information or context related to this pull request.