NRL-2015 option 4 - choose v2 if v2 permissions file in lambda layer by anjalitrace2-nhs · Pull Request #1172 · NHSDigital/NRLF

anjalitrace2-nhs · 2026-03-17T14:12:20Z

TODO:

Remove all references to v1 vs v2 in integration tests now that v1 & v2 requests have the same headers
Write an extra integration test that falls back to v1 when a v2 file isn't present (but a neighbouring ODS is :| )

github-actions · 2026-03-17T14:15:49Z

💥 Something went wrong while building the pull request environment.
Check Output Logs

github-actions · 2026-03-17T14:21:30Z

💥 Something went wrong while building the pull request environment.
Check Output Logs

github-actions · 2026-03-19T14:09:00Z

💥 Something went wrong while building the pull request environment.
Check Output Logs

…v2 permissions file. No longer decide based on missing v1 headers. In order to lookup v2 permissions file we need v2 headers though

github-actions · 2026-03-19T17:57:48Z

🚀 PR environment successfully deployed.
Commit Hash: e49fd0e33858a6868ae428fdd99900ec2538c5c8
URL: https://nrl2015-01ba47.api.record-locator.dev.national.nhs.uk/

github-actions · 2026-03-20T11:03:37Z

🚀 PR environment successfully deployed.
Commit Hash: ed6254d30512a70a46fc53ca7460c2fcd39f1967
URL: https://nrl2015-01ba47.api.record-locator.dev.national.nhs.uk/

github-actions · 2026-03-20T11:22:03Z

🚀 PR environment successfully deployed.
Commit Hash: d7cf9543eb520fb07303dbfbf62eb6379a0323bc
URL: https://nrl2015-01ba47.api.record-locator.dev.national.nhs.uk/

… or v2 determined by v2 file present rahter than request headers

…tion-4

sonarqubecloud · 2026-03-20T12:07:26Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-03-20T12:08:29Z

🚀 PR environment successfully deployed.
Commit Hash: 29e931520ba96a98f73efddfe538a585b932d2c7
URL: https://nrl2015-01ba47.api.record-locator.dev.national.nhs.uk/

github-actions · 2026-03-20T12:16:41Z

🚀 PR environment successfully deployed.
Commit Hash: d66af6a5a03fb5470bc99c939156761a0819c2aa
URL: https://nrl2015-01ba47.api.record-locator.dev.national.nhs.uk/

anjalitrace2-nhs had a problem deploying to pull-request March 17, 2026 14:12 — with GitHub Actions Failure

anjalitrace2-nhs temporarily deployed to pull-request March 17, 2026 14:12 — with GitHub Actions Inactive

anjalitrace2-nhs had a problem deploying to pull-request March 17, 2026 14:12 — with GitHub Actions Failure

anjalitrace2-nhs force-pushed the NRL-2015-option-4 branch from 6d13ba8 to 8ff73e2 Compare March 17, 2026 14:19

anjalitrace2-nhs had a problem deploying to pull-request March 17, 2026 14:19 — with GitHub Actions Failure

anjalitrace2-nhs temporarily deployed to pull-request March 17, 2026 14:19 — with GitHub Actions Inactive

NRL-2015 option 4 propsed changes

07d1abc

anjalitrace2-nhs force-pushed the NRL-2015-option-4 branch from 8ff73e2 to 07d1abc Compare March 19, 2026 14:05

anjalitrace2-nhs had a problem deploying to pull-request March 19, 2026 14:05 — with GitHub Actions Failure

anjalitrace2-nhs temporarily deployed to pull-request March 19, 2026 14:05 — with GitHub Actions Inactive

anjalitrace2-nhs had a problem deploying to pull-request March 19, 2026 14:05 — with GitHub Actions Failure

NRL-2015 decide whether to use v2 perimssions based on presence of a …

e49fd0e

…v2 permissions file. No longer decide based on missing v1 headers. In order to lookup v2 permissions file we need v2 headers though

anjalitrace2-nhs temporarily deployed to pull-request March 19, 2026 17:50 — with GitHub Actions Inactive

anjalitrace2-nhs temporarily deployed to pull-request March 19, 2026 17:53 — with GitHub Actions Inactive

anjalitrace2-nhs temporarily deployed to pull-request March 19, 2026 17:54 — with GitHub Actions Inactive

anjalitrace2-nhs had a problem deploying to pull-request March 19, 2026 17:57 — with GitHub Actions Failure

anjalitrace2-nhs added 2 commits March 19, 2026 18:32

NRL-2015 unit tests for all cases now that I'm out of the soup

517a10f

NRL-2015 add v1 & v2 headers to all integration tests

ed6254d

anjalitrace2-nhs temporarily deployed to pull-request March 20, 2026 10:57 — with GitHub Actions Inactive

anjalitrace2-nhs temporarily deployed to pull-request March 20, 2026 11:00 — with GitHub Actions Inactive

anjalitrace2-nhs temporarily deployed to pull-request March 20, 2026 11:01 — with GitHub Actions Inactive

anjalitrace2-nhs had a problem deploying to pull-request March 20, 2026 11:03 — with GitHub Actions Failure

NRL-2015 use unique app id for v2 integration tests

d7cf954

anjalitrace2-nhs temporarily deployed to pull-request March 20, 2026 11:16 — with GitHub Actions Inactive

anjalitrace2-nhs temporarily deployed to pull-request March 20, 2026 11:19 — with GitHub Actions Inactive

anjalitrace2-nhs temporarily deployed to pull-request March 20, 2026 11:22 — with GitHub Actions Inactive

anjalitrace2-nhs temporarily deployed to pull-request March 20, 2026 11:24 — with GitHub Actions Inactive

anjalitrace2-nhs changed the title ~~NRL-2015 option 4 propsed changes~~ NRL-2015 option 4 - choose v2 if v2 permissions file in lambda layer Mar 20, 2026

anjalitrace2-nhs marked this pull request as ready for review March 20, 2026 11:40

anjalitrace2-nhs requested a review from a team as a code owner March 20, 2026 11:40

NRL-2015 remove all references to v1 or v2 in setup steps now that v1…

29e9315

… or v2 determined by v2 file present rahter than request headers

anjalitrace2-nhs temporarily deployed to pull-request March 20, 2026 12:01 — with GitHub Actions Inactive

anjalitrace2-nhs marked this pull request as draft March 20, 2026 12:01

Merge branch 'develop' of github.com:NHSDigital/NRLF into NRL-2015-op…

d66af6a

…tion-4

anjalitrace2-nhs temporarily deployed to pull-request March 20, 2026 12:02 — with GitHub Actions Inactive

anjalitrace2-nhs temporarily deployed to pull-request March 20, 2026 12:06 — with GitHub Actions Inactive

anjalitrace2-nhs temporarily deployed to pull-request March 20, 2026 12:10 — with GitHub Actions Inactive

anjalitrace2-nhs deployed to pull-request March 20, 2026 12:13 — with GitHub Actions Active

anjalitrace2-nhs had a problem deploying to pull-request March 20, 2026 12:16 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NRL-2015 option 4 - choose v2 if v2 permissions file in lambda layer#1172

NRL-2015 option 4 - choose v2 if v2 permissions file in lambda layer#1172
anjalitrace2-nhs wants to merge 7 commits intodevelopfrom
NRL-2015-option-4

anjalitrace2-nhs commented Mar 17, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

sonarqubecloud bot commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

anjalitrace2-nhs commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

sonarqubecloud bot commented Mar 20, 2026

Quality Gate passed

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

anjalitrace2-nhs commented Mar 17, 2026 •

edited

Loading