NRL-1554 Add new content retrieval mechanism extension by eesa456 · Pull Request #1005 · NHSDigital/NRLF

eesa456 · 2025-08-11T10:14:45Z

No description provided.

github-actions · 2025-08-11T10:21:36Z

🚀 PR environment successfully deployed.
Commit Hash: 37e7375a1e9484ca5d023f433e405b7e6cc97546
URL: https://nrl1554-ac2cba.api.record-locator.dev.national.nhs.uk/

github-actions · 2025-08-11T10:33:44Z

🚀 PR environment successfully deployed.
Commit Hash: 2d9deb024e8a8acb686b8ce8332c2d3b689a09ae
URL: https://nrl1554-ac2cba.api.record-locator.dev.national.nhs.uk/

github-actions · 2025-08-11T10:42:01Z

🚀 PR environment successfully deployed.
Commit Hash: 5424d1da30cd4d07f4926e3a8b00c53c9ff2639e
URL: https://nrl1554-ac2cba.api.record-locator.dev.national.nhs.uk/

github-actions · 2025-08-11T10:51:39Z

🚀 PR environment successfully deployed.
Commit Hash: 317008883d28abc3515927c4104161aa577eed1b
URL: https://nrl1554-ac2cba.api.record-locator.dev.national.nhs.uk/

github-actions · 2025-08-11T11:04:17Z

🚀 PR environment successfully deployed.
Commit Hash: ef781377da1db99550872a80f00635016b91297f
URL: https://nrl1554-ac2cba.api.record-locator.dev.national.nhs.uk/

github-actions · 2025-08-27T13:14:56Z

🚀 PR environment successfully deployed.
Commit Hash: 5761aea9321afdeab7a3dffd2b97781959963627
URL: https://nrl1554-ac2cba.api.record-locator.dev.national.nhs.uk/

github-actions · 2025-08-28T16:40:49Z

🚀 PR environment successfully deployed.
Commit Hash: 307228f81aac14a109ce1e03aa545fe1f839fb00
URL: https://nrl1554-ac2cba.api.record-locator.dev.national.nhs.uk/

github-actions · 2025-08-28T17:03:37Z

🚀 PR environment successfully deployed.
Commit Hash: 0c1edb768172e4c0514111aa9068802e87360deb
URL: https://nrl1554-ac2cba.api.record-locator.dev.national.nhs.uk/

github-actions · 2025-09-02T08:52:15Z

🚀 PR environment successfully deployed.
Commit Hash: 10e9c4f93185734446c10b40cc0d2dd4b448ab79
URL: https://nrl1554-ac2cba.api.record-locator.dev.national.nhs.uk/

mattdean3-nhs

LGTM - only thing that needs changing is LDR = Large Document Retrieval. I leave the extra unit test stuff up to you.

api/consumer/swagger.yaml

layer/nrlf/core/validators.py

github-actions · 2025-09-05T08:34:06Z

🚀 PR environment successfully deployed.
Commit Hash: e9922751cbaea52ebd58b865592e13ce5c6c3bb0
URL: https://nrl1554-ac2cba.api.record-locator.dev.national.nhs.uk/

github-actions · 2025-09-05T09:45:00Z

🚀 PR environment successfully deployed.
Commit Hash: 8789b7742288f38fa4582eeb8edee2e31eb6833a
URL: https://nrl1554-ac2cba.api.record-locator.dev.national.nhs.uk/

mattdean3-nhs

LGTM 💪

Just one comment about some unused parameterized args - rest is bob on.

layer/nrlf/core/tests/test_validators.py

mattdean3-nhs · 2025-09-05T11:42:50Z

layer/nrlf/core/tests/test_validators.py

+    )
+
+
+def test_has_valid_extensions():


loving these 🙌

github-actions · 2025-09-05T13:15:59Z

🚀 PR environment successfully deployed.
Commit Hash: 5ad1a553a7a39906a6f06dc45f0e1a99a993e0ef
URL: https://nrl1554-ac2cba.api.record-locator.dev.national.nhs.uk/

sonarqubecloud · 2025-09-05T13:27:50Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-09-05T13:33:20Z

🚀 PR environment successfully deployed.
Commit Hash: 1ffa66a2f295657943e129cc2cb7eb263815b9db
URL: https://nrl1554-ac2cba.api.record-locator.dev.national.nhs.uk/

NRL-1554 Add new content retrieval mechanism extension

4ed5144

eesa456 temporarily deployed to pull-request August 11, 2025 10:14 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request August 11, 2025 10:18 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request August 11, 2025 10:21 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request August 11, 2025 10:23 — with GitHub Actions Inactive

NRL-1554 sonar qube fixes

9fd7818

eesa456 temporarily deployed to pull-request August 11, 2025 10:27 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request August 11, 2025 10:31 — with GitHub Actions Inactive

eesa456 had a problem deploying to pull-request August 11, 2025 10:33 — with GitHub Actions Failure

NRL-1554 reduce complexity

a523b94

eesa456 temporarily deployed to pull-request August 11, 2025 10:35 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request August 11, 2025 10:38 — with GitHub Actions Inactive

eesa456 had a problem deploying to pull-request August 11, 2025 10:42 — with GitHub Actions Failure

NRL-1554 add retrieval mechanism extension to int tests

2790ae2

eesa456 temporarily deployed to pull-request August 11, 2025 10:45 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request August 11, 2025 10:58 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request August 11, 2025 11:01 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request August 11, 2025 11:04 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request August 11, 2025 11:05 — with GitHub Actions Inactive

axelkrastek1-nhs temporarily deployed to pull-request August 27, 2025 12:44 — with GitHub Actions Inactive

NRL-1554 Add test for two contents with different retrieval mechanisms

0b32adc

axelkrastek1-nhs temporarily deployed to pull-request August 27, 2025 13:08 — with GitHub Actions Inactive

axelkrastek1-nhs temporarily deployed to pull-request August 27, 2025 13:11 — with GitHub Actions Inactive

axelkrastek1-nhs temporarily deployed to pull-request August 27, 2025 13:15 — with GitHub Actions Inactive

axelkrastek1-nhs temporarily deployed to pull-request August 27, 2025 13:16 — with GitHub Actions Inactive

NRL-1554 Change order of display to match the code

7357fdf

axelkrastek1-nhs temporarily deployed to pull-request August 28, 2025 16:34 — with GitHub Actions Inactive

axelkrastek1-nhs temporarily deployed to pull-request August 28, 2025 16:37 — with GitHub Actions Inactive

axelkrastek1-nhs had a problem deploying to pull-request August 28, 2025 16:40 — with GitHub Actions Failure

NRL-1554 Reduce cognitive complexity

6fa21a6

axelkrastek1-nhs temporarily deployed to pull-request August 28, 2025 16:56 — with GitHub Actions Inactive

NRL-1554 Fix integration test

e444ccc

mattdean3-nhs reviewed Sep 2, 2025

View reviewed changes

api/consumer/swagger.yaml Outdated Show resolved Hide resolved

layer/nrlf/core/validators.py Show resolved Hide resolved

NRL-1554 Retrieval instead of Repository, add unit tests

0e81e6a

mattdean3-nhs previously approved these changes Sep 5, 2025

View reviewed changes

NRL-1554 Fix unit test

1ffa66a

mattdean3-nhs approved these changes Sep 8, 2025

View reviewed changes

		)


		def test_has_valid_extensions():

Conversation

eesa456 commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 27, 2025

Uh oh!

github-actions bot commented Aug 28, 2025

Uh oh!

github-actions bot commented Aug 28, 2025

Uh oh!

github-actions bot commented Sep 2, 2025

Uh oh!

mattdean3-nhs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 5, 2025

Uh oh!

github-actions bot commented Sep 5, 2025

Uh oh!

mattdean3-nhs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mattdean3-nhs Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 5, 2025

Uh oh!

sonarqubecloud bot commented Sep 5, 2025

Quality Gate passed

Uh oh!

github-actions bot commented Sep 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants