Use most recent watermedia for 1.20 #72
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Second this 👍 |
Owner
|
Thanks for the commits, I will check it ASAP! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VideoPlayer mod was not working with watermedia 2.1.x. I have changed that, so now the mod works with most recent watermedia (and WaterFrames). That also means the mod does not work with watermedia 2.0.x anymore (wich I don't think is a problem?).
Also addded portuguese translations because i'm from Brazil and felt like it.
By the way, I'm not a modder. I'm just a dev who wanted to use this mod with the newest version of watermedia because the old version didn't work with WaterFrames and I really wanted to use both at the same time.
I'm not sure everything is correct as I have no idea what ALL the code does. I tested what I needed to test, it worked, I'm trying to contribute with other people.
Let me know if you need more changes and your thoughts on this PR.